[java] Fixing Safari initialization code to be able to use Safari TP

SeleniumHQ · Jul 11, 2019 · a4ec9e9 · a4ec9e9
1 parent 3637786
commit a4ec9e9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/java/client/src/org/openqa/selenium/safari/SafariDriverService.java b/java/client/src/org/openqa/selenium/safari/SafariDriverService.java
@@ -59,7 +59,7 @@ public static SafariDriverService createDefaultService() {
   }
 
   static SafariDriverService createDefaultService(SafariOptions options) {
-    return new Builder().build();
+    return new Builder().usingTechnologyPreview(options.getUseTechnologyPreview()).build();
   }
 
   static SafariDriverService createDefaultService(Capabilities caps) {
@@ -128,7 +128,7 @@ protected File findDefaultExecutable() {
         throw new WebDriverException(message.toString());
       }
 
-      return SAFARI_DRIVER_EXECUTABLE;
+      return exe;
     }
 
     private boolean isElCapitanOrLater() {

diff --git a/java/client/src/org/openqa/selenium/safari/SafariOptions.java b/java/client/src/org/openqa/selenium/safari/SafariOptions.java
@@ -110,7 +110,7 @@ public static SafariOptions fromCapabilities(Capabilities capabilities)
     } else if (cap instanceof Map) {
       return new SafariOptions(new MutableCapabilities(((Map<String, ?>) cap)));
     } else {
-      return new SafariOptions();
+      return new SafariOptions(capabilities);
     }
   }
 

diff --git a/java/client/test/org/openqa/selenium/testing/drivers/DefaultDriverSupplier.java b/java/client/test/org/openqa/selenium/testing/drivers/DefaultDriverSupplier.java
@@ -52,7 +52,7 @@ public class DefaultDriverSupplier implements Supplier<WebDriver> {
   private Capabilities capabilities;
 
   DefaultDriverSupplier(Capabilities capabilities) {
-    this.capabilities = new ImmutableCapabilities(capabilities);
+    this.capabilities = capabilities;
   }
 
   @Override