Skip to content

Commit

Permalink
[rust] Fix condition to download browser in discover local browser logic
Browse files Browse the repository at this point in the history
  • Loading branch information
bonigarcia committed Nov 14, 2023
1 parent 8cd85d5 commit aeb0d62
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions rust/src/lib.rs
Expand Up @@ -427,7 +427,8 @@ pub trait SeleniumManager {
}

fn discover_local_browser(&mut self) -> Result<(), Error> {
if !self.is_force_browser_download() {
let mut download_browser = self.is_force_browser_download();
if !download_browser {
let major_browser_version = self.get_major_browser_version();
match self.discover_browser_version()? {
Some(discovered_version) => {
Expand Down Expand Up @@ -463,7 +464,7 @@ pub trait SeleniumManager {
self.get_browser_name(),
discovered_major_browser_version,
));
self.set_download_browser(true);
download_browser = true;
}
} else {
self.set_browser_version(discovered_version);
Expand All @@ -478,7 +479,7 @@ pub trait SeleniumManager {
discovered_major_browser_version,
major_browser_version,
));
self.set_download_browser(true);
download_browser = true;
} else {
self.set_browser_version(discovered_version);
}
Expand All @@ -498,10 +499,11 @@ pub trait SeleniumManager {
self.get_browser_name(),
self.get_browser_version_label()
));
self.set_download_browser(true);
download_browser = true;
}
}
}
self.set_download_browser(download_browser);

Ok(())
}
Expand Down

0 comments on commit aeb0d62

Please sign in to comment.