Skip to content

Commit

Permalink
Fixing IE driver to ignore unknown timeouts for set timeout command
Browse files Browse the repository at this point in the history
  • Loading branch information
jimevans committed Jul 17, 2019
1 parent 7e8bd71 commit bbc80e1
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions cpp/iedriver/CommandHandlers/SetTimeoutsCommandHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ void SetTimeoutsCommandHandler::ExecuteInternal(
for (; timeout_parameter_iterator != command_parameters.end(); ++timeout_parameter_iterator) {
std::string timeout_type = timeout_parameter_iterator->first;
Json::Value timeout_value = timeout_parameter_iterator->second;
if (timeout_type != IMPLICIT_WAIT_TIMEOUT_NAME &&
timeout_type != SCRIPT_TIMEOUT_NAME &&
timeout_type != PAGE_LOAD_TIMEOUT_NAME) {
response->SetErrorResponse(ERROR_INVALID_ARGUMENT,
"Invalid timeout type specified: " + timeout_type);
return;
}
if (timeout_type == SCRIPT_TIMEOUT_NAME && timeout_value.isNull()) {
// Special case for the script timeout, which is nullable.
mutable_executor.set_async_script_timeout(-1);
Expand Down

0 comments on commit bbc80e1

Please sign in to comment.