Unignoring .NET alert text tests for Chrome that pass in Dev channel

SeleniumHQ · Jul 11, 2019 · c0b9b28 · c0b9b28
1 parent 13b9007
commit c0b9b28
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/dotnet/test/common/AlertsTest.cs b/dotnet/test/common/AlertsTest.cs
@@ -529,8 +529,6 @@ public void ShouldHandleAlertOnWindowClose()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Driver chooses not to return text from unhandled alert")]
-        [IgnoreBrowser(Browser.Edge, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.EdgeLegacy, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Firefox, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Opera)]

diff --git a/dotnet/test/common/ExecutingAsyncJavascriptTest.cs b/dotnet/test/common/ExecutingAsyncJavascriptTest.cs
@@ -4,10 +4,7 @@
 
 namespace OpenQA.Selenium
 {
-    // TODO: Remove NeedsFreshDriver attribute when ChromeDriver moves
-    // to default of using W3C protocol dialect
     [TestFixture]
-    [NeedsFreshDriver(IsCreatedAfterTest = true)]
     public class ExecutingAsyncJavascriptTest : DriverTestFixture
     {
         private IJavaScriptExecutor executor;
@@ -278,7 +275,6 @@ public void ShouldBeAbleToMakeXMLHttpRequestsAndWaitForTheResponse()
         }
 
         [Test]
-       // [IgnoreBrowser(Browser.Chrome, "Driver does not handle async alerts in OSS protocol dialect mode")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
 		public void ThrowsIfScriptTriggersAlert()
@@ -293,7 +289,6 @@ public void ThrowsIfScriptTriggersAlert()
         }
 
         [Test]
-        //[IgnoreBrowser(Browser.Chrome, "Driver does not handle async alerts in OSS protocol dialect mode")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfAlertHappensDuringScript()
@@ -308,7 +303,6 @@ public void ThrowsIfAlertHappensDuringScript()
         }
 
         [Test]
-        //[IgnoreBrowser(Browser.Chrome, "Driver does not handle async alerts in OSS protocol dialect mode")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfScriptTriggersAlertWhichTimesOut()
@@ -324,7 +318,6 @@ public void ThrowsIfScriptTriggersAlertWhichTimesOut()
         }
 
         [Test]
-        //[IgnoreBrowser(Browser.Chrome, "Driver does not handle async alerts in OSS protocol dialect mode")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
@@ -339,8 +332,6 @@ public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Driver chooses not to return text from unhandled alert")]
-        [IgnoreBrowser(Browser.Edge, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.EdgeLegacy, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Firefox, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]