Skip to content

Commit

Permalink
Updating supported .NET Framework versions
Browse files Browse the repository at this point in the history 
This removes support for .NET Framework 3.5 and .NET Framework 4.0.
Going forward, the minimum supported framework for the .NET language
bindings is .NET 4.5. We will produce binaries for .NET Framework 4.5,
4.6, 4.7, and .NET Standard 2.0. While it would be theoretically
possible to allow the .NET Standard binary to suffice for 4.6.1 or
above, in practice, doing so adds many additional assemblies added to
the output directory, which is a suboptimal outcome. .NET Framework
4.7.1 is the first version that supports .NET Standard 2.0 without the
need for these additional assemblies.
  • Loading branch information
@jimevans
jimevans committed Apr 10, 2019
1 parent 46891fa commit dfc2d1c
Show file tree
Hide file tree
Showing 13 changed files with 43 additions and 46 deletions.
9 changes: 4 additions & 5 deletions dotnet/src/support/WebDriver.Support.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;net40;net35;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net47;net46;net45;netstandard2.0</TargetFrameworks>
<AssemblyName>WebDriver.Support</AssemblyName>
<RootNamespace>OpenQA.Selenium.Support</RootNamespace>
<BuildSystem>visual-studio</BuildSystem>
Expand All @@ -16,16 +16,15 @@
</PropertyGroup>

<PropertyGroup>
<FrameworkPathOverride Condition="'$(TargetFramework)'=='net35'">C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v3.5\Profile\Client</FrameworkPathOverride>
<AssemblyTitle>Selenium WebDriver Support</AssemblyTitle>
<Description>Selenium WebDriver .NET Bindings support classes</Description>
<Company>Selenium Committers</Company>
<Copyright>Copyright © Software Freedom Conservancy 2018</Copyright>
<Product>Selenium</Product>
<Version>3</Version>
<Version>4</Version>
<PackageId>Selenium.Support</PackageId>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
<FileVersion>3.0.0.0</FileVersion>
<AssemblyVersion>4.0.0.0</AssemblyVersion>
<FileVersion>4.0.0.0</FileVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net35|AnyCPU'">
Expand Down
35 changes: 17 additions & 18 deletions dotnet/src/webdriver/WebDriver.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;net40;net35;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net47;net46;net45;netstandard2.0</TargetFrameworks>
<AssemblyName>WebDriver</AssemblyName>
<RootNamespace>OpenQA.Selenium</RootNamespace>
<BuildSystem>visual-studio</BuildSystem>
Expand All @@ -16,42 +16,41 @@
</PropertyGroup>

<PropertyGroup>
<FrameworkPathOverride Condition="'$(TargetFramework)'=='net35'">C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v3.5\Profile\Client</FrameworkPathOverride>
<AssemblyTitle>WebDriver</AssemblyTitle>
<Description>Selenium WebDriver API .NET Bindings</Description>
<Company>Selenium Committers</Company>
<Copyright>Copyright © Software Freedom Conservancy 2018</Copyright>
<Product>Selenium</Product>
<Version>3</Version>
<Version>4</Version>
<PackageId>Selenium.WebDriver</PackageId>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
<FileVersion>3.0.0.0</FileVersion>
<AssemblyVersion>4.0.0.0</AssemblyVersion>
<FileVersion>4.0.0.0</FileVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net35|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net35\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net45|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net45\WebDriver.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net35|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net35\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net45|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net45\WebDriver.xml</DocumentationFile>
<WarningLevel>0</WarningLevel>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net40|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net40\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net46|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net46\WebDriver.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net40|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net40\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net46|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net46\WebDriver.xml</DocumentationFile>
<WarningLevel>0</WarningLevel>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net45|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net45\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net47|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net40\WebDriver.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net45|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net45\WebDriver.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net47|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net40\WebDriver.xml</DocumentationFile>
<WarningLevel>0</WarningLevel>
</PropertyGroup>

Expand Down Expand Up @@ -102,7 +101,7 @@
</ItemGroup>

<Target Name="PostBuild" AfterTargets="PostBuildEvent" Condition="'$(BuildSystem)' == 'visual-studio' And '$(OS)' == 'Windows_NT'">
<Exec Command="for %%G in (net35 net40 net45 netstandard2.0) do (&#xD;&#xA; if exist &quot;$(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&quot; (&#xD;&#xA; echo Found IE 32-bit native binary, copying from Win32 build target $(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Missing IE 32-bit native binary, copying from Win32 prebuilt location $(ProjectDir)..\..\..\cpp\prebuilt\Win32\Release\IEDriverServer.exe&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\cpp\prebuilt\Win32\Release\IEDriverServer.exe&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA; )&#xD;&#xA;&#xD;&#xA; echo Copying Firefox preferences file from $(ProjectDir)..\..\..\javascript\firefox-driver\webdriver.json&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\javascript\firefox-driver\webdriver.json&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA;&#xD;&#xA; if not exist &quot;$(TargetDir)..\%%G\getAttribute.js&quot; (&#xD;&#xA; if not exist &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\webdriver\atoms\get-attribute.js&quot; (&#xD;&#xA; echo Building getAttribute atom&#xD;&#xA; pushd &quot;$(ProjectDir)..\..\..&quot;&#xD;&#xA; call &quot;go.bat&quot; //javascript/webdriver/atoms:get-attribute&#xD;&#xA; popd&#xD;&#xA; )&#xD;&#xA; echo Copying getAttribute atom&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\webdriver\atoms\get-attribute.js&quot; &quot;$(TargetDir)..\%%G\getAttribute.js&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Found getAttribute atom at $(TargetDir)..\%%G\getAttribute.js.&#xD;&#xA; )&#xD;&#xA;&#xD;&#xA; if not exist &quot;$(TargetDir)..\%%G\isDisplayed.js&quot; (&#xD;&#xA; if not exist &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\atoms\fragments\is-displayed.js&quot; (&#xD;&#xA; echo Building isDisplayed atom&#xD;&#xA; pushd &quot;$(ProjectDir)..\..\..&quot;&#xD;&#xA; call &quot;go.bat&quot; //javascript/atoms/fragments:is-displayed&#xD;&#xA; popd&#xD;&#xA; )&#xD;&#xA; echo Copying isDisplayed atom&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\atoms\fragments\is-displayed.js&quot; &quot;$(TargetDir)..\%%G\isDisplayed.js&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Found isDisplayed atom at $(TargetDir)..\%%G\isDisplayed.js.&#xD;&#xA; )&#xD;&#xA;)" />
<Exec Command="for %%G in (net45 net46 net47 netstandard2.0) do (&#xD;&#xA; if exist &quot;$(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&quot; (&#xD;&#xA; echo Found IE 32-bit native binary, copying from Win32 build target $(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\build\cpp\Win32\$(ConfigurationName)\IEDriverServer.exe&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Missing IE 32-bit native binary, copying from Win32 prebuilt location $(ProjectDir)..\..\..\cpp\prebuilt\Win32\Release\IEDriverServer.exe&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\cpp\prebuilt\Win32\Release\IEDriverServer.exe&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA; )&#xD;&#xA;&#xD;&#xA; echo Copying Firefox preferences file from $(ProjectDir)..\..\..\javascript\firefox-driver\webdriver.json&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\javascript\firefox-driver\webdriver.json&quot; &quot;$(TargetDir)..\%%G&quot; &gt; NUL&#xD;&#xA;&#xD;&#xA; if not exist &quot;$(TargetDir)..\%%G\getAttribute.js&quot; (&#xD;&#xA; if not exist &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\webdriver\atoms\get-attribute.js&quot; (&#xD;&#xA; echo Building getAttribute atom&#xD;&#xA; pushd &quot;$(ProjectDir)..\..\..&quot;&#xD;&#xA; call &quot;go.bat&quot; //javascript/webdriver/atoms:get-attribute&#xD;&#xA; popd&#xD;&#xA; )&#xD;&#xA; echo Copying getAttribute atom&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\webdriver\atoms\get-attribute.js&quot; &quot;$(TargetDir)..\%%G\getAttribute.js&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Found getAttribute atom at $(TargetDir)..\%%G\getAttribute.js.&#xD;&#xA; )&#xD;&#xA;&#xD;&#xA; if not exist &quot;$(TargetDir)..\%%G\isDisplayed.js&quot; (&#xD;&#xA; if not exist &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\atoms\fragments\is-displayed.js&quot; (&#xD;&#xA; echo Building isDisplayed atom&#xD;&#xA; pushd &quot;$(ProjectDir)..\..\..&quot;&#xD;&#xA; call &quot;go.bat&quot; //javascript/atoms/fragments:is-displayed&#xD;&#xA; popd&#xD;&#xA; )&#xD;&#xA; echo Copying isDisplayed atom&#xD;&#xA; copy /y &quot;$(ProjectDir)..\..\..\buck-out\gen\javascript\atoms\fragments\is-displayed.js&quot; &quot;$(TargetDir)..\%%G\isDisplayed.js&quot; &gt; NUL&#xD;&#xA; ) else (&#xD;&#xA; echo Found isDisplayed atom at $(TargetDir)..\%%G\isDisplayed.js.&#xD;&#xA; )&#xD;&#xA;)" />
</Target>

<Target Name="PostBuild" AfterTargets="PostBuildEvent" Condition="'$(BuildSystem)' == 'visual-studio' And '$(OS)' != 'Windows_NT'">
Expand Down
21 changes: 10 additions & 11 deletions dotnet/src/webdriverbackedselenium/Selenium.WebDriverBackedSelenium.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;net40;net35;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net47;net46;net45;netstandard2.0</TargetFrameworks>
<AssemblyName>Selenium.WebDriverBackedSelenium</AssemblyName>
<RootNamespace>Selenium</RootNamespace>
<BuildSystem>visual-studio</BuildSystem>
Expand All @@ -16,7 +16,6 @@
</PropertyGroup>

<PropertyGroup>
<FrameworkPathOverride Condition="'$(TargetFramework)'=='net35'">C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v3.5\Profile\Client</FrameworkPathOverride>
<AssemblyTitle>Selenium WebDriver WebDriverBackedSelenium</AssemblyTitle>
<Description>Selenium RC API using WebDriver .NET Bindings</Description>
<Company>Selenium Committers</Company>
Expand All @@ -28,21 +27,21 @@
<FileVersion>3.0.0.0</FileVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net35|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net35\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net47|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net47\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net35|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net35\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net47|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net47\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<WarningLevel>0</WarningLevel>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net40|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net40\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net46|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Release\net46\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net40|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net40\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net46|AnyCPU'">
<DocumentationFile>..\..\..\build\cli\Debug\net46\Selenium.WebDriverBackedSelenium.xml</DocumentationFile>
<WarningLevel>0</WarningLevel>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion dotnet/test/chrome/WebDriver.Chrome.Tests.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netcoreapp2.0</TargetFrameworks>
<TargetFrameworks>net47;netcoreapp2.0</TargetFrameworks>
<AssemblyName>WebDriver.Chrome.Tests</AssemblyName>
</PropertyGroup>

Expand Down

0 comments on commit dfc2d1c

Please sign in to comment.