Mark tests as expected to pass and update rubocop config (#7278)

* Update rubocop config - Ignore coumments when counting lines in class, method, moudle * Expect Chrome to pass double-click test
SeleniumHQ · Jun 11, 2019 · e55f334 · e55f334
1 parent 965a996
commit e55f334
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/rb/.rubocop.yml b/rb/.rubocop.yml
@@ -71,7 +71,8 @@ Metrics/CyclomaticComplexity:
     - 'spec/integration/selenium/webdriver/spec_support/test_environment.rb'
 
 Metrics/ClassLength:
-  Max: 140
+  CountComments: false
+  Max: 150
   Exclude:
     - 'lib/selenium/webdriver/firefox/profile.rb'
     - 'lib/selenium/webdriver/remote/bridge.rb'
@@ -98,11 +99,13 @@ Metrics/LineLength:
       - '^\s*#'
 
 Metrics/ModuleLength:
+  CountComments: false
   Exclude:
     - 'lib/selenium/webdriver/common/platform.rb'
     - 'spec/**/*'
 
 Metrics/MethodLength:
+  CountComments: false
   Max: 33
   Exclude:
     - 'lib/selenium/webdriver/chrome/driver.rb'

diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -143,7 +143,7 @@ module WebDriver
           expect(text).to eq('Dropped!')
         end
 
-        it 'double clicks an element', except: {browser: %i[chrome safari safari_preview]} do
+        it 'double clicks an element', except: {browser: %i[safari safari_preview]} do
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'doubleClickField')