[rb] setting log path in Chromium needs to pass an argument instead o…

…f piping process

Performance Logging can not be used without enabling logging with --log-path

rb/lib/selenium/webdriver/chrome/service.rb

@@ -24,6 +24,13 @@ class Service < WebDriver::Service
         DEFAULT_PORT = 9515
         EXECUTABLE = 'chromedriver'
         SHUTDOWN_SUPPORTED = true
+
+        def log
+          return @log unless @log.is_a? String
+
+          @args += ['--log-path', @log]
+          @log = nil
+        end
       end # Service
     end # Chrome
   end # WebDriver

rb/lib/selenium/webdriver/common/service_manager.rb

@@ -40,8 +40,8 @@ def initialize(config)
         @executable_path = config.executable_path
         @host = Platform.localhost
         @port = config.port
-        @extra_args = config.args
         @io = config.log
+        @extra_args = config.args
         @shutdown_supported = config.shutdown_supported
 
         raise Error::WebDriverError, "invalid port: #{@port}" if @port < 1

rb/lib/selenium/webdriver/edge/service.rb

@@ -24,6 +24,13 @@ class Service < WebDriver::Service
         DEFAULT_PORT = 9515
         EXECUTABLE = 'msedgedriver'
         SHUTDOWN_SUPPORTED = true
+
+        def log
+          return @log unless @log.is_a? String
+
+          @args += ['--log-path', @log]
+          @log = nil
+        end
       end # Service
     end # Edge
   end # WebDriver

rb/spec/unit/selenium/webdriver/chrome/service_spec.rb

@@ -33,7 +33,7 @@ module Chrome
           after { described_class.driver_path = nil }
 
           it 'uses nil path and default port' do
-            service = described_class.chrome
+            service = described_class.new
 
             expect(service.port).to eq Service::DEFAULT_PORT
             expect(service.host).to eq Platform.localhost
@@ -44,7 +44,7 @@ module Chrome
             path = 'foo'
             port = 5678
 
-            service = described_class.chrome(path: path, port: port)
+            service = described_class.new(path: path, port: port)
 
             expect(service.executable_path).to eq path
             expect(service.port).to eq port
@@ -58,19 +58,26 @@ module Chrome
           end
 
           it 'uses sets log path to stdout' do
-            service = described_class.chrome(log: :stdout)
+            service = described_class.new(log: :stdout)
 
             expect(service.log).to eq $stdout
           end
 
           it 'uses sets log path to stderr' do
-            service = described_class.chrome(log: :stderr)
+            service = described_class.new(log: :stderr)
 
             expect(service.log).to eq $stderr
           end
 
+          it 'setting log output as a file converts to argument' do
+            service = described_class.new(log: '/path/to/log.txt')
+
+            expect(service.log).to be_nil
+            expect(service.args).to eq ['--log-path', '/path/to/log.txt']
+          end
+
           it 'uses provided args' do
-            service = described_class.chrome(args: ['--foo', '--bar'])
+            service = described_class.new(args: ['--foo', '--bar'])
 
             expect(service.extra_args).to eq ['--foo', '--bar']
           end

rb/spec/unit/selenium/webdriver/edge/service_spec.rb

@@ -56,6 +56,25 @@ module Edge
             expect(service.extra_args).to be_empty
           end
 
+          it 'uses sets log path to stdout' do
+            service = described_class.chrome(log: :stdout)
+
+            expect(service.log).to eq $stdout
+          end
+
+          it 'uses sets log path to stderr' do
+            service = described_class.chrome(log: :stderr)
+
+            expect(service.log).to eq $stderr
+          end
+
+          it 'setting log output as a file converts to argument' do
+            service = described_class.chrome(log: '/path/to/log.txt')
+
+            expect(service.log).to be_nil
+            expect(service.args).to eq ['--log-path', '/path/to/log.txt']
+          end
+
           it 'uses provided args' do
             service = described_class.new(args: ['--foo', '--bar'])
 
@@ -106,6 +125,13 @@ module Edge
             driver.new(service: service)
             expect(described_class).not_to have_received(:new)
           end
+
+          it 'setting log output as a file converts to argument' do
+            service = described_class.chrome(log: '/path/to/log.txt')
+
+            expect(service.log).to be_nil
+            expect(service.args).to eq ['--log-path', '/path/to/log.txt']
+          end
         end
       end
     end # Edge

rb/spec/unit/selenium/webdriver/firefox/service_spec.rb

@@ -54,6 +54,24 @@ module Firefox
             expect(service.extra_args).to be_empty
           end
 
+          it 'uses sets log path to stdout' do
+            service = described_class.new(log: :stdout)
+
+            expect(service.log).to eq $stdout
+          end
+
+          it 'uses sets log path to stderr' do
+            service = described_class.new(log: :stderr)
+
+            expect(service.log).to eq $stderr
+          end
+
+          it 'sets log path as file location' do
+            service = described_class.new(log: '/path/to/log.txt')
+
+            expect(service.log).to eq '/path/to/log.txt'
+          end
+
           it 'uses provided args' do
             service = described_class.new(args: ['--foo', '--bar'])
 

rb/spec/unit/selenium/webdriver/ie/service_spec.rb

@@ -55,6 +55,24 @@ module IE
             expect(service.extra_args).to be_empty
           end
 
+          it 'uses sets log path to stdout' do
+            service = described_class.new(log: :stdout)
+
+            expect(service.log).to eq $stdout
+          end
+
+          it 'uses sets log path to stderr' do
+            service = described_class.new(log: :stderr)
+
+            expect(service.log).to eq $stderr
+          end
+
+          it 'sets log path as file location' do
+            service = described_class.new(log: '/path/to/log.txt')
+
+            expect(service.log).to eq '/path/to/log.txt'
+          end
+
           it 'uses provided args' do
             service = described_class.new(args: ['--foo', '--bar'])