Skip to content

Commit

Permalink
Disabling Firefox-specific tests in .NET
Browse files Browse the repository at this point in the history
The code paths being tested by the tests hasn't changed in years,
the tests are not run on a consistent basis, and even when they are
run, the results are largely ignored. The tests are still here for
historical reasons, and can be re-enabled quickly should the need
arise.
  • Loading branch information
jimevans committed Dec 17, 2018
1 parent 13866be commit f87a732
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
18 changes: 9 additions & 9 deletions dotnet/test/firefox/FirefoxDriverTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace OpenQA.Selenium.Firefox
[TestFixture]
public class FirefoxDriverTest : DriverTestFixture
{
[Test]
//[Test]
public void ShouldContinueToWorkIfUnableToFindElementById()
{
driver.Url = formsPage;
Expand All @@ -29,7 +29,7 @@ public void ShouldContinueToWorkIfUnableToFindElementById()
driver.Url = xhtmlTestPage;
}

[Test]
//[Test]
public void ShouldWaitUntilBrowserHasClosedProperly()
{
driver.Url = simpleTestPage;
Expand All @@ -48,7 +48,7 @@ public void ShouldWaitUntilBrowserHasClosedProperly()
Assert.AreEqual(expectedText, seenText);
}

[Test]
//[Test]
public void ShouldBeAbleToStartMoreThanOneInstanceOfTheFirefoxDriverSimultaneously()
{
IWebDriver secondDriver = new FirefoxDriver();
Expand All @@ -63,7 +63,7 @@ public void ShouldBeAbleToStartMoreThanOneInstanceOfTheFirefoxDriverSimultaneous
secondDriver.Quit();
}

[Test]
//[Test]
public void ShouldBeAbleToStartANamedProfile()
{
FirefoxProfile profile = new FirefoxProfileManager().GetProfile("default");
Expand All @@ -80,7 +80,7 @@ public void ShouldBeAbleToStartANamedProfile()
}
}

[Test]
//[Test]
public void ShouldRemoveProfileAfterExit()
{
FirefoxProfile profile = new FirefoxProfile();
Expand All @@ -93,7 +93,7 @@ public void ShouldRemoveProfileAfterExit()
Assert.IsFalse(Directory.Exists(profileLocation));
}

[Test]
//[Test]
[NeedsFreshDriver(IsCreatedBeforeTest = true, IsCreatedAfterTest = true)]
public void FocusRemainsInOriginalWindowWhenOpeningNewWindow()
{
Expand All @@ -117,7 +117,7 @@ public void FocusRemainsInOriginalWindowWhenOpeningNewWindow()
Assert.AreEqual("ABC DEF", keyReporter.GetAttribute("value"));
}

[Test]
//[Test]
[NeedsFreshDriver(IsCreatedBeforeTest = true, IsCreatedAfterTest = true)]
public void SwitchingWindowShouldSwitchFocus()
{
Expand Down Expand Up @@ -162,7 +162,7 @@ public void SwitchingWindowShouldSwitchFocus()
Assert.AreEqual("QWERTY", keyReporter2.GetAttribute("value"));
}

[Test]
//[Test]
[NeedsFreshDriver(IsCreatedBeforeTest = true, IsCreatedAfterTest = true)]
public void ClosingWindowAndSwitchingToOriginalSwitchesFocus()
{
Expand Down Expand Up @@ -230,7 +230,7 @@ public void CanBlockInvalidSslCertificates()
}
}

[Test]
//[Test]
public void ShouldAllowUserToSuccessfullyOverrideTheHomePage()
{
FirefoxProfile profile = new FirefoxProfile();
Expand Down
10 changes: 5 additions & 5 deletions dotnet/test/firefox/FirefoxProfileManagerTest.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using NUnit.Framework;
using NUnit.Framework;

namespace OpenQA.Selenium.Firefox
{
Expand All @@ -13,28 +13,28 @@ public void SetUp()
manager = new FirefoxProfileManager();
}

[Test]
//[Test]
public void ShouldGetNamedProfile()
{
FirefoxProfile profile = manager.GetProfile("default");
Assert.IsNotNull(profile);
}

[Test]
//[Test]
public void ShouldReturnNullForInvalidProfileName()
{
FirefoxProfile profile = manager.GetProfile("ThisIsMyBogusProfileName");
Assert.IsNull(profile);
}

[Test]
//[Test]
public void ShouldReturnNullForNullProfileName()
{
FirefoxProfile profile = manager.GetProfile(null);
Assert.IsNull(profile);
}

[Test]
//[Test]
public void ShouldReturnNullForEmptyProfileName()
{
FirefoxProfile profile = manager.GetProfile(string.Empty);
Expand Down
8 changes: 4 additions & 4 deletions dotnet/test/firefox/FirefoxProfileTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Collections.Generic;
using System.Collections.Generic;
using NUnit.Framework;

namespace OpenQA.Selenium.Firefox
Expand All @@ -20,7 +20,7 @@ public void TearDown()
profile.Clean();
}

[Test]
//[Test]
public void ShouldQuoteStringsWhenSettingStringProperties()
{
profile.SetPreference("cheese", "brie");
Expand All @@ -38,7 +38,7 @@ public void ShouldQuoteStringsWhenSettingStringProperties()
Assert.IsTrue(seenCheese);
}

[Test]
//[Test]
public void ShouldSetIntegerPreferences()
{
profile.SetPreference("cheese", 1234);
Expand All @@ -56,7 +56,7 @@ public void ShouldSetIntegerPreferences()
Assert.IsTrue(seenCheese, "Did not see integer value being set correctly");
}

[Test]
//[Test]
public void testShouldSetBooleanPreferences()
{
profile.SetPreference("cheese", false);
Expand Down

0 comments on commit f87a732

Please sign in to comment.