[Grid] Adding a test to check that remoteHost is properly read and set.

SeleniumHQ · Nov 7, 2018 · fea6316 · fea6316
1 parent 5b0a928
commit fea6316
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/java/server/test/org/openqa/grid/internal/BaseRemoteProxyTest.java b/java/server/test/org/openqa/grid/internal/BaseRemoteProxyTest.java
@@ -123,6 +123,24 @@ public void proxyConfigOverwritesRegistryConfig() {
     assertEquals(50L, p.getConfig().maxSession.longValue());
   }
 
+  @Test
+  public void remoteHostParameterIsTakenInProxyAndRegistry() {
+    GridRegistry registry = DefaultGridRegistry.newInstance(new Hub(new GridHubConfiguration()));
+
+    GridNodeConfiguration nodeConfiguration = parseCliOptions("-remoteHost", "http://machine1:5555");
+    RegistrationRequest req = RegistrationRequest.build(nodeConfiguration);
+    req.getConfiguration().proxy = null;
+
+    RemoteProxy p = BaseRemoteProxy.getNewInstance(req, registry);
+    registry.add(p);
+
+    // values which are present in both the registration request and the registry need to
+    // come from the registration request
+    assertEquals("http://machine1:5555", p.getConfig().getRemoteHost());
+    assertEquals("http://machine1:5555",
+                 registry.getProxyById(p.getId()).getRemoteHost().toExternalForm());
+  }
+
   @Test
   public void proxyTakesRemoteAsIdIfIdNotSpecified() {
     String remoteHost ="http://machine1:5555";