Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📄 Add Detail Pages for Definitions #53

Closed
ovlb opened this issue Feb 6, 2020 · 10 comments · Fixed by #75
Closed

📄 Add Detail Pages for Definitions #53

ovlb opened this issue Feb 6, 2020 · 10 comments · Fixed by #75
Assignees

Comments

@ovlb
Copy link
Collaborator

ovlb commented Feb 6, 2020

As the site grows, the homepage gets more and more crowded and impossible to scan. I think we should link to detail pages for single definitions (e.g. /definitions/crazy instead of #crazy).

Edit: I keep track of this issue and update the to-do list in #75. So have a look there for the current status

@tatianamac
Copy link
Collaborator

tatianamac commented Feb 12, 2020

Agree with this change for sure! It was always the hope that the site would grow. 🤗 (tries not to get weird and emo)

We should be mindful though of future linking strategies when coming up with the canonical link. For example, one hope is to be able to concatenate terms so someone can theoretically link to serve up a page that shows all the terms they identify as:

?queer+disabled+wheelchair-user
Full context and discussion here: #6

So, tl;dr, let's do it, as long as we feel confident the above scenario can be addressed as we start to look at broader database needs

@ovlb
Copy link
Collaborator Author

ovlb commented Feb 12, 2020

Yip. The combined pages are definitely a part of it. I think they might even become simpler once we have these detail pages, as we can already start defining a layout :)

My reasoning for /definitions/word is that the homepage might change in the future and become more of an overview introducing the whole project with its bots, API and so forth. By having an URL scope for the definitions we avoid dealing with redirects in the future when we might want to have the API info page at /api.

Is it okay if I take this issue?

@tatianamac
Copy link
Collaborator

Yes, awesome, I'm so glad you're such a holistic thinker! 🤗

Also I should add that we need to create redirects as there are some links out in the world already for /#word. Should I open up a new issue for this?

@ovlb
Copy link
Collaborator Author

ovlb commented Feb 12, 2020

I think that’s an acceptance criteria for closing this issue.

I’ll add a to-do list to the OP asap to make the scope of this issue clearer. :)

@ovlb
Copy link
Collaborator Author

ovlb commented Feb 12, 2020

@tatianamac I’ve added a to-do list. Anything else that comes to mind?

@tatianamac tatianamac added the Type · Definitions Relates to specific definitions label Feb 13, 2020
@tatianamac
Copy link
Collaborator

Looks good!

What is the intention of next/last links? Do they link to the next and previous words alphabetically? I worry a bit about what we mean by this when we consider sub-terms would theoretically appear twice in the full list, if that makes sense.

(For example, cis appears both under C (cis) and G (cisgender).)

@tatianamac tatianamac added Type · Feature Enhancement Improve existing feature and removed Type · Definitions Relates to specific definitions labels Feb 13, 2020
@ovlb
Copy link
Collaborator Author

ovlb commented Feb 13, 2020

I thought it is a nice touch for the page, to encourage browsing around. Probably have thought about it because I like the game «open a dictionary and read whatever words show up» so much. The Duden (german dictionary) has a similar feature at the bottom of their definition pages: https://www.duden.de/rechtschreibung/Geviert

Random feature idea: A «Show me a random definition»-button on the homepage.

@ovlb
Copy link
Collaborator Author

ovlb commented Feb 13, 2020

One solution for the sub-terms might be to include only the main term «gender» while somewhere around «ge» and cisgender while browsing around «ci». In any way, cisgender will be shown in the sub-terms of gender on the detail page of gender.

@tatianamac
Copy link
Collaborator

I think this a good solution for right now. I have a feeling I'm missing some edge cases right now

One solution for the sub-terms might be to include only the main term «gender» while somewhere around «ge» and cisgender while browsing around «ci». In any way, cisgender will be shown in the sub-terms of gender on the detail page of gender.

@ovlb
Copy link
Collaborator Author

ovlb commented Feb 15, 2020

I think this a good solution for right now. I have a feeling I'm missing some edge cases right now

There will be edge cases :D We will fix them once they poke us too hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants