Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"take" is not work as expected #41

Closed
makarkotlov opened this issue Oct 30, 2019 · 3 comments
Closed

"take" is not work as expected #41

makarkotlov opened this issue Oct 30, 2019 · 3 comments

Comments

@makarkotlov
Copy link
Contributor

makarkotlov commented Oct 30, 2019

That
image
will show
image
instead of
image

@makarkotlov makarkotlov changed the title "take" is not works as expected "take" is not work as expected Oct 30, 2019
@selfrefactor
Copy link
Owner

This is how Ramda behaves as you can see here:
https://ramdajs.com/repl/#?R.take%281%2C%20%5B%5B%201%2C%202%2C%203%20%5D%5D%29

@makarkotlov
Copy link
Contributor Author

This is how Ramda behaves as you can see here:
https://ramdajs.com/repl/#?R.take%281%2C%20%5B%5B%201%2C%202%2C%203%20%5D%5D%29

Thank you, but do you think that this is the right behavior?

@selfrefactor
Copy link
Owner

The latest major bump of Rambda was exactly to close as possible the difference in methods - selfrefactor/rambda#276

All the failing Ramda tests are displayed in Ramda readme witch click upon this test Expand to see allRamdatests failing forRambda, if you want to know in detail the difference between the two libraries.

Moreover, all of those failing tests are kept in https://github.com/selfrefactor/rambda/tree/master/files/failing_ramda_tests folder.

If Ramda change its behavior, then I will follow suit, but for now this is how it is.

I try to enhance Ramda rather than change existing behavior - for example R.filter in Rambda supports objects, while Ramda work only with arrays. Or introducing more return types from R.type.

At some point, Idecide not to match Ramda functionality, but that is exception, rather than a rule. I will close the issue, but feel free to comment further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants