Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function throttle returned undefined #76

Closed
aamree opened this issue Dec 20, 2021 · 3 comments
Closed

Function throttle returned undefined #76

aamree opened this issue Dec 20, 2021 · 3 comments

Comments

@aamree
Copy link

aamree commented Dec 20, 2021

Hello. Function throttle doesn't return value. Returned undefined.
rambdax version: 7.4.1
sample: https://codesandbox.io/s/affectionate-mcclintock-xh7mk?file=/src/App.js
Please fix this bag.

@aamree aamree changed the title Function thorttle returned undefined Function thorottle returned undefined Dec 20, 2021
@aamree aamree changed the title Function thorottle returned undefined Function throttle returned undefined Dec 20, 2021
@selfrefactor
Copy link
Owner

This is a good catch as I checked against Lodash's throttle and indeed it returns a result. I will apply the fix to debounce as well.

The fix will be published in upcoming version 8.0.0 of Rambdax. Thank you for bringing this up.

@selfrefactor
Copy link
Owner

selfrefactor commented Dec 27, 2021

A fix is applied and it will be published with upcoming 8.0.0 version. I added return type only to R.throttle, but R.debounce still doesn't return a value as this is also how Lodash's debounce works.

@selfrefactor
Copy link
Owner

Closing as version 8.0.0 was deployed with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants