Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken HTML #163

Closed
selfthinker opened this issue Mar 25, 2018 · 2 comments
Closed

Broken HTML #163

selfthinker opened this issue Mar 25, 2018 · 2 comments
Labels

Comments

@selfthinker
Copy link
Owner

The example syntax page currently produces broken HTML when using DokuWiki's master branch but not in the stable branch. A couple of divs are not closed.
I assumed that was due to the section edit changes but now that they are fixed in #162 the HTML is still broken.

When I diff output of the syntax page between master and stable, I get the following three changes:

  • The group wrap around the three columns at the top does neither open nor close. So, that doesn't contribute to any broken HTML but it is wrong as well.
  • The div after the table in the #width section doesn't close. Not sure if it's div.table or div.wrap_column.
  • The div at the end of the #outer_box_floats_right section doesn't close either. It's either corresponding to the outer box wrap or the inner tip wrap.
@selfthinker
Copy link
Owner Author

This has definitely something to do with the section edit changes because when I comment all the section edit stuff within syntax/div.php, then everything is fine.

@selfthinker
Copy link
Owner Author

This was fixed in the DokuWiki core (see /dokuwiki/dokuwiki#2304).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant