-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orca.py stucks in a loop if no NBO analysis was done #52
Comments
This shouldn't cause Q-Force to be stuck and it should be handled more gracefully, but note that you do not seem to have set NBO environment variable for ORCA, Q-Force needs this for the bond order analysis:
|
@vbochenkov Thanks for reporting. Do you mind uploading a new ORCA log file with the NBO set up correctly? It seems that ORCA has now removed the string |
Unfortunately, I don't have NBO, so I cannot set it up. I didn't realize that it is mandatory to have it to run qforce. :( |
@vbochenkov, if you have access to Gaussian, Q-Chem, or xTB, all these methods have either NBO or a bond order analysis tool included in them. |
@selimsami, I have access to Firefly, it has NBO tool. So, perhaps, I'll have to work to add a module for Qforce to support Firefly :) |
Appreciated! Note that xTB is free and open source, so you could use it to to test Q-Force before you decide to help the development. |
Cool! Thanks for the idea! I'll check it. |
@selimsami Do you have a plan of deprecating the lone pair? If the requirement for lone pair is deprecated, I could make it that ORCA will not need NBO and we won't have these issues. |
Oh nice! Then I will work on this |
@xiki-tempula, this will take me a bit longer. There is some dependency on lone pairs for atom type detection. But I should be able get around that, probably next week. |
@xiki-tempula, depreciation done, see #55 |
@vbochenkov Do you mind trying the latest version? The ORCA requirement for NBO has been removed now. |
Hi @xiki-tempula, I've got the following error message while testing the new version:
NOTE: QM atomic charges are scaled by 1.2 to account for the condensed phase polarization. Traceback (most recent call last): AttributeError: 'NoneType' object has no attribute 'actualSolve'The Orca produced files are attached. |
@vbochenkov , I did not manage to reproduce your issue with the files you have provided, it worked fine for me. Were you using the latest GitHub version or the pypi version? I have now pushed the update to pypi as well (0.6.5), so could you please try again with:
If that doesn't work, can you try upgrading PuLP:
And let me know which step solved your problem. |
@selimsami, thank you for the suggestion. I had to upgrade PuLP, and now it works fine! I'm closing the issue. Thanks for your help! |
Hi @xiki-tempula,
qforce seems to be stuck trying to find the string "Now starting NBO analysis" (in line 468, in _read_orca_nbo_analysis) in orca output file. Here is the file: propane_hessian.log
The text was updated successfully, but these errors were encountered: