Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test: breaks and labels are different #33

Closed
selkamand opened this issue Mar 10, 2023 · 0 comments · Fixed by #34
Closed

Add unit test: breaks and labels are different #33

selkamand opened this issue Mar 10, 2023 · 0 comments · Fixed by #34

Comments

@selkamand
Copy link
Owner

Should consider adding a unit test for this:

df <- data.frame(col = c(0, 0, NA, NA, NA, NA, NA, NA, 0, NA))
expect_error(gg1d_plot(df, cols_to_plot="col1"), NA)

Since theres only 1 non-na value (0) an old version of gg1d would throw an error message about breaks and labels being different lengths. We fixed the issue but should add a unit test to catch future instances

@selkamand selkamand linked a pull request Mar 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant