-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio randomly gets disabled after latest changes to webrtcbin #109
Comments
This issue has been tagged as Urgent. |
I believe that this issue is because the audio and video WebRTC elements do not cross-check that both protocols have been connected successfully. |
How do you reproduce this? |
@danisla Try to reload the web interface multiple times. Especially from a non-local connection passing through the internet. It's not guaranteed to happen every time, but I have at least one other user reproducing this. The core problem is that the current code seemingly does not ensure that both WebRTC streams are established before exposing the web interface to the user. |
It seems like this is shown even when audio is active. Stats are not shown. |
@Xosrov Could I ask how you solved this problem? |
Hey, I don't recall such an issue, but I did have a look at the new source code and I notice something: if audio_only:
self.build_audio_pipeline()
else:
self.build_video_pipeline() This implies the The way I had implemented it was to first preroll the capturing + encoding + packetizing pipeline, then attach and sync a specific Some other things (unrelated to this topic,) that you could consider adding to POSSIBLY improve the whole stream experience:
I hope this helps. |
Thanks for the massive help. @Xosrov |
Applied these two things in 6d16d00. |
I understand that this is the same issue as #131. Please reopen if there are additional issues. |
There is still an issue where one should ensure both WebRTC (video, audio) streams are connected before the start button is shown, and the reload button should be shown after failure in either of the two streams. |
Please reopen if there are additional issues. |
Because the option to turn on and off audio was removed, it is expected that audio should always be on.
However, the audio goes off randomly.
It could be because we should check that both audio and video WebRTC streams, as well as the RTCDataChannel, are all connected before we declare the connection is established successfully. There is a possibility that this was omitted in the latest commits.
This has been reproduced by myself and a user who has reported the issue to me.
The metrics menu may, but not necessarily show the following:
The text was updated successfully, but these errors were encountered: