Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] Improve how RTCDataChannel works / Implement chunked transport for WebRTC DataChannel #74

Open
ehfd opened this issue Jan 18, 2023 · 1 comment
Open

[META] Improve how RTCDataChannel works / Implement chunked transport for WebRTC DataChannel #74

ehfd opened this issue Jan 18, 2023 · 1 comment
Labels
enhancement New feature or request help wanted External contribution is required transport Underlying media or data transport protocols web Web components including gst-web

Comments

@ehfd
Copy link
Member

ehfd commented Jan 18, 2023 •
edited

The issue #43 has been patched by #73, but the core issue is that there is no graceful handling for a DataChannel message which is above the size of 65535 bytes.

Therefore, it would be VERY useful to implement chunked messages for DataChannels, as the benefit can be applicable to any workload which can use DataChannel messages between the client and server using WebRTC.

If implemented, remove the restrictions placed by:

selkies-gstreamer/src/selkies_gstreamer/gstwebrtc_app.py

Line 758 in 1f2070b

# TODO: WebRTC DataChannel accepts a maximum length of 65489 (= 65535 - 46 for '{"type": "clipboard", "data": {"content": ""}}'), remove this restriction after implementing DataChannel chunking

@ehfd ehfd added enhancement New feature or request help wanted External contribution is required transport Underlying media or data transport protocols web Web components including gst-web labels Jan 18, 2023
This was referenced Jan 18, 2023
Closed
Open
@ehfd ehfd changed the title Implement chunking for WebRTC DataChannel Improve how RTCDataChannel Works / Implement chunking for WebRTC DataChannel Oct 1, 2023
@ehfd ehfd changed the title Improve how RTCDataChannel Works / Implement chunking for WebRTC DataChannel Improve how RTCDataChannel works / Implement chunking for WebRTC DataChannel Oct 1, 2023
@ehfd ehfd mentioned this issue Oct 12, 2023
Open
@ehfd ehfd changed the title Improve how RTCDataChannel works / Implement chunking for WebRTC DataChannel Improve how RTCDataChannel works / Implement chunked transport for WebRTC DataChannel Oct 12, 2023
@ehfd ehfd changed the title Improve how RTCDataChannel works / Implement chunked transport for WebRTC DataChannel [META] Improve how RTCDataChannel works / Implement chunked transport for WebRTC DataChannel Oct 12, 2023
@ehfd
Copy link
Member Author

ehfd commented Mar 21, 2024

https://groups.google.com/g/discuss-webrtc/c/f3dfmu3oh00

@ehfd ehfd mentioned this issue Mar 24, 2024
Open
26 tasks
@ehfd ehfd mentioned this issue Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted External contribution is required transport Underlying media or data transport protocols web Web components including gst-web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehfd