Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoutingStack.Element: Enforce correct hashCode and equals #58

Closed
sellmair opened this issue Apr 14, 2019 · 1 comment · Fixed by #59
Closed

RoutingStack.Element: Enforce correct hashCode and equals #58

sellmair opened this issue Apr 14, 2019 · 1 comment · Fixed by #59
Labels
0.2.0 Ticket is only relevant for the 0.2.0 prototype enhancement
Milestone
0.2.0

Comments

@sellmair
Copy link
Owner

Wrong equals or hashCode implementations will result in silently breaking behaviours in DefaultFragmentStackPatcher .
e.g. fragments will be removed to early, since they cannot be found in the newStack
@sellmair sellmair added the 0.2.0 Ticket is only relevant for the 0.2.0 prototype label Apr 14, 2019
@sellmair sellmair added this to the 0.2.0 milestone Apr 14, 2019
@sellmair sellmair added the test label Apr 14, 2019
@sellmair
Copy link
Owner Author

This also requires that the ElementImpl implements a correct hashCode and equals function!

@sellmair sellmair changed the title Tests for FragmentElementImpl RoutingStack.Element: Enforce correct hashCode and equals Apr 14, 2019
@sellmair sellmair added enhancement and removed test labels Apr 14, 2019
@sellmair sellmair mentioned this issue Apr 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.2.0 Ticket is only relevant for the 0.2.0 prototype enhancement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Enhancement/58 enforce routing stack element equals and hashcode sellmair/kompass
1 participant
@sellmair