Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display joined missions in My profile #38

Merged
merged 3 commits into from Apr 6, 2022
Merged

Conversation

selma-belhadj
Copy link
Owner

What does this PR do?

This PR is raised to add the request to display joined missions in My profile page.

Description of the task to be completed

  • Render a list of all joined missions (use filter()) on the "My profile" page.

How should it be tested

  • clone the repository
    git clone https://github.com/selma-belhadj/space-travelers.git
  • navigate to the folder
    cd space-travelers
  • checkout the feature
    git checkout missions-fetch-list
  • Install packages
    npm install
  • Create build app
    npm run build
  • Run the app
    npm start

@selma-belhadj selma-belhadj linked an issue Apr 6, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for team-space-travelers ready!

Name Link
🔨 Latest commit 393db37
🔍 Latest deploy log https://app.netlify.com/sites/team-space-travelers/deploys/624da109deffb900080a5325
😎 Deploy Preview https://deploy-preview-38--team-space-travelers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@awais-amjed awais-amjed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected. Just add spacing class to the page to make it consistent with other pages.

Alt Text

@selma-belhadj selma-belhadj merged commit 57d7237 into dev Apr 6, 2022
@selma-belhadj selma-belhadj deleted the profile-joined-missions branch April 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Display joined missions in My profile - Filters
2 participants