Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent round #46

Open
dusan-ivanco opened this issue Apr 26, 2022 · 0 comments
Open

transparent round #46

dusan-ivanco opened this issue Apr 26, 2022 · 0 comments

Comments

@dusan-ivanco
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch sharingan-rn-modal-dropdown@1.4.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/sharingan-rn-modal-dropdown/src/Dropdown/index.tsx b/node_modules/sharingan-rn-modal-dropdown/src/Dropdown/index.tsx
index 62216af..30442a3 100644
--- a/node_modules/sharingan-rn-modal-dropdown/src/Dropdown/index.tsx
+++ b/node_modules/sharingan-rn-modal-dropdown/src/Dropdown/index.tsx
@@ -326,7 +326,7 @@ const Dropdown: React.FC<IDropdownProps> = props => {
         >
           <View
             style={{
-              backgroundColor: colors.background,
+              backgroundColor: floating ? colors.background : 'transparent',
               width: !floating ? contMeasure.vWidth : 'auto',
               left: !floating ? contMeasure.vx : 0,
               top: !floating ? contMeasure.vy : 100,
diff --git a/node_modules/sharingan-rn-modal-dropdown/src/GroupDropdown/index.tsx b/node_modules/sharingan-rn-modal-dropdown/src/GroupDropdown/index.tsx
index 68ba362..789b43e 100644
--- a/node_modules/sharingan-rn-modal-dropdown/src/GroupDropdown/index.tsx
+++ b/node_modules/sharingan-rn-modal-dropdown/src/GroupDropdown/index.tsx
@@ -350,7 +350,7 @@ const GroupDropdown: React.FC<IGroupDropdownProps> = props => {
           >
             <View
               style={{
-                backgroundColor: 'transparent',
+                backgroundColor: floating ? colors.background : 'transparent',
                 width: !floating ? contMeasure.vWidth : 'auto',
                 left: !floating ? contMeasure.vx : 0,
                 top: !floating ? contMeasure.vy : 100,
diff --git a/node_modules/sharingan-rn-modal-dropdown/src/MultiselectDropdown/index.tsx b/node_modules/sharingan-rn-modal-dropdown/src/MultiselectDropdown/index.tsx
index 291e90e..5f624f6 100644
--- a/node_modules/sharingan-rn-modal-dropdown/src/MultiselectDropdown/index.tsx
+++ b/node_modules/sharingan-rn-modal-dropdown/src/MultiselectDropdown/index.tsx
@@ -412,7 +412,7 @@ const MultiselectDropdown: React.FC<IMultiselectDropdownProps> = props => {
         >
           <View
             style={{
-              backgroundColor: colors.background,
+              backgroundColor: floating ? colors.background : 'transparent',
               width: !floating ? contMeasure.vWidth : 'auto',
               left: !floating ? contMeasure.vx : 0,
               top: !floating ? contMeasure.vy : 100,

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant