Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Czech translation #20

Merged
merged 3 commits into from Dec 4, 2021
Merged

Improved Czech translation #20

merged 3 commits into from Dec 4, 2021

Conversation

Jujan
Copy link
Contributor

@Jujan Jujan commented Oct 23, 2021

A lot of strings were reworked to better fit situation.
The rework is not complete.
I need screenshots of the strings in app to examine the situation and make proper changes.
The strings I need to see are on lines 13, 14, 15, 16, 18, 19 and 24.

A lot of strings were reworked to better fit situation. There are still changes to do, but I need proper assistance in making the strings appear in app. I can examine rest of the strings after assistance.
@semack
Copy link
Owner

semack commented Oct 23, 2021

Hi,

Julian, thank you very much for your contribution.
We could add your suggestions and publish a new build.

@Jujan
Copy link
Contributor Author

Jujan commented Oct 23, 2021

@semack Nice to hear. I will mark this pull request as ready as soon as I translate the rest of strings. Would you help me out?
I need to see in which situations these strings on lines 13, 14, 15, 16, 18, 19 and 24 appear in app on device. I need screenshots as I have no idea how to reproduce these lines.

@semack
Copy link
Owner

semack commented Oct 23, 2021

It wont help, cuz different devices have different screen sizes.

@Jujan
Copy link
Contributor Author

Jujan commented Oct 23, 2021

@semack We might be in miscommunication here. When does string on line 13 appears? What is the trigger event?

@semack
Copy link
Owner

semack commented Oct 23, 2021

You always can check the sources. If you mean `"load_failed_retry": "Load failed, tap to retry..."', it will appear on communication problems in the search grid. It will appear at bottom of it.

@semack
Copy link
Owner

semack commented Oct 23, 2021

14 - is similar to Not Available. N/A
15 - if no compatible tape files found on the player screen
16 - title on app bar when selecting the local file from storage
18 - retry button if communication problems on any request too remote source
19 - error message when the problem of retrieving the tape file from remote.

@Jujan
Copy link
Contributor Author

Jujan commented Oct 23, 2021

@semack Exactly what I need. Thanks. I am no programmer. :) Making changes accordingly. Where is the "Not Available" to be seen? What about 24?

@semack
Copy link
Owner

semack commented Oct 23, 2021

24 - Notification after the long press on the selected file if you wish to download it to the storage.

@semack
Copy link
Owner

semack commented Oct 23, 2021

Not Available, please leave it as "-"

I have consulted the translation with other Czech speaking residents and have agreed on accuracy of this translation.
@Jujan
Copy link
Contributor Author

Jujan commented Dec 4, 2021

Okay. Thanks for your cooperation on this topic. Final version of translation is complete. The pull request is ready to go.

@Jujan Jujan marked this pull request as ready for review December 4, 2021 16:13
@semack semack merged commit faf8b9d into semack:master Dec 4, 2021
@Jujan Jujan deleted the patch-1 branch December 4, 2021 18:58
@semack
Copy link
Owner

semack commented Dec 4, 2021

@Jujan Published for both platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants