feat: throw error when "name" key is missing in package.json #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Aug 17, 2019
src/lib/npm.js
Outdated
| @@ -55,7 +55,7 @@ async function validateToken(otp, npm) { | |||
|
|
|||
| function getRegistry(pkg, conf) { | |||
| if (pkg.publishConfig && pkg.publishConfig.registry) return pkg.publishConfig.registry; | |||
|
|
|||
| if (pkg.name === undefined) throw new Error(`Your package doesn't have name`); | |||
There was a problem hiding this comment.
Suggested change
| if (pkg.name === undefined) throw new Error(`Your package doesn't have name`); | |
| if (pkg.name === undefined) throw new Error(`package.json is missing "name" key`); |
I'm not sure if this is the right place to throw the error, I'd throw it as soon as we read out pkg. The name property is not used in the getRegistry method
There was a problem hiding this comment.
the next line is using the name property name[0], but I agree with you, it could be better if we placed it in the index.js.
abdelrahmanahmed
commented
Dec 8, 2019
| @@ -10,6 +10,7 @@ const ownPkg = require('../package.json'); | |||
| const getLog = require('./lib/log'); | |||
|
|
|||
| const pkg = JSON.parse(readFileSync('./package.json')); | |||
| if (pkg.name === undefined) throw new Error(`"name" key is missing from your package.json`); | |||
There was a problem hiding this comment.
Hi @gr2m, I updated my PR and moved the validation from getRegistry method in npm.js in the index.js after reading the package.json directly
gr2m
changed the title
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #297