fix(github): Remove deprecated GitHub Basic Auth flow #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Jan 2, 2021
src/lib/github.js
Outdated
| message: 'What is your GitHub password?', | ||
| validate: _.ary(_.bind(validator.isLength, validator, _, 1), 1), | ||
| name: 'token', | ||
| message: 'What is your GitHub personal access token?', |
There was a problem hiding this comment.
Maybe change it to
Suggested change
| message: 'What is your GitHub personal access token?', | |
| message: 'Provide a GItHub Personal Access Token (create a token at https://github.com/settings/tokens/new?scopes=repo)', |
There was a problem hiding this comment.
I updated the message as requested @gr2m . I did some local testing to check that it could handle passed in gh-token as well as default to the answer supplied by the CLI prompt if needed. I didn't run the projejct end to end on a project of mine to test, should I do that? I wasn't sure how far to test.
|
馃帀 This PR is included in version 5.4.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
Thanks @gr2m 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What