Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release/github does not support repositories prefixed with dot #225

Closed
kuwas opened this issue Oct 18, 2019 · 5 comments · Fixed by #226
Closed

semantic-release/github does not support repositories prefixed with dot #225

kuwas opened this issue Oct 18, 2019 · 5 comments · Fixed by #226

Comments

@kuwas
Copy link

kuwas commented Oct 18, 2019

For some reason only this plugin interprets .github repo name to github and attempts to release to the wrong repo. Maybe its related to the parse-github-url package being used to do the parsing? I dont see semantic-release/release-notes-generator using this package.

Please see logs below, notice how semantic-release:release-notes-generator interprets repository: '.github' and semantic-release:github interprets release repo: 'github'

[11:38:39 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:38:39 AM] [semantic-release] › ℹ  There is no previous release, the next release version is 1.0.0
[11:38:39 AM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
  semantic-release:release-notes-generator version: '1.0.0' +0ms
  semantic-release:release-notes-generator host: undefined +0ms
  semantic-release:release-notes-generator owner: 'npm' +0ms
  semantic-release:release-notes-generator repository: '.github' +1ms
  semantic-release:release-notes-generator previousTag: undefined +0ms
  semantic-release:release-notes-generator currentTag: 'v1.0.0' +0ms
  semantic-release:release-notes-generator host: 'https://github.com' +0ms
  semantic-release:release-notes-generator host: 'https://github.com' +0ms
  semantic-release:release-notes-generator linkReferences: undefined +0ms
  semantic-release:release-notes-generator issue: 'issues' +0ms
  semantic-release:release-notes-generator commit: 'commit' +0ms
[11:38:39 AM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[11:38:42 AM] [semantic-release] › ✔  Created tag v1.0.0
[11:38:42 AM] [semantic-release] › ℹ  Start step "publish" of plugin "@semantic-release/github"
  semantic-release:github release owner: 'npm' +0ms
  semantic-release:github release repo: 'github' +0ms
  semantic-release:github release name: 'v1.0.0' +0ms
  semantic-release:github release branch: 'master' +0ms
[11:38:42 AM] [semantic-release] [@semantic-release/github] › ℹ  Published GitHub release: https://github.com/npm/github/releases/tag/v1.0.0
[11:38:42 AM] [semantic-release] › ✔  Completed step "publish" of plugin "@semantic-release/github"
[11:38:42 AM] [semantic-release] › ℹ  Start step "success" of plugin "@semantic-release/github"
@pvdlg
Copy link
Member

pvdlg commented Oct 18, 2019

What is the repository.url configured in your package.json?

@kuwas
Copy link
Author

kuwas commented Oct 18, 2019

@pvdlg I should mention that this has already been tried, but I tried it again just now, see below.

{
  "license": "ISC",
  "version": "0.0.0",
  "name": "@npmcorp/.github",
  "repository": {
    "type": "git",
    "url": "https://github.com/npm/.github.git"
  },
  "private": false,
  "dependencies": {
    "@semantic-release/git": "7.0.16",
    "@semantic-release/github": "5.5.3",
    "@semantic-release/npm": "5.2.0",
    "@semantic-release/commit-analyzer": "6.3.0",
    "@semantic-release/release-notes-generator": "7.3.0",
    "semantic-release": "15.13.24"
  },
  "release": {
    "extends": "./cloud.js"
  }
}
[1:35:48 PM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[1:35:48 PM] [semantic-release] › ℹ  There is no previous release, the next release version is 1.0.0
[1:35:48 PM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
  semantic-release:release-notes-generator version: '1.0.0' +0ms
  semantic-release:release-notes-generator host: undefined +0ms
  semantic-release:release-notes-generator owner: 'npm' +0ms
  semantic-release:release-notes-generator repository: '.github' +0ms
  semantic-release:release-notes-generator previousTag: undefined +0ms
  semantic-release:release-notes-generator currentTag: 'v1.0.0' +0ms
  semantic-release:release-notes-generator host: 'https://github.com' +0ms
  semantic-release:release-notes-generator host: 'https://github.com' +0ms
  semantic-release:release-notes-generator linkReferences: undefined +0ms
  semantic-release:release-notes-generator issue: 'issues' +0ms
  semantic-release:release-notes-generator commit: 'commit' +0ms
[1:35:48 PM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[1:35:50 PM] [semantic-release] › ✔  Created tag v1.0.0
[1:35:50 PM] [semantic-release] › ℹ  Start step "publish" of plugin "@semantic-release/github"
  semantic-release:github release owner: 'npm' +0ms
  semantic-release:github release repo: 'github' +0ms
  semantic-release:github release name: 'v1.0.0' +1ms
  semantic-release:github release branch: 'master' +0ms
[1:35:51 PM] [semantic-release] [@semantic-release/github] › ℹ  Published GitHub release: https://github.com/npm/github/releases/tag/v1.0.0
[1:35:51 PM] [semantic-release] › ✔  Completed step "publish" of plugin "@semantic-release/github"
[1:35:51 PM] [semantic-release] › ℹ  Start step "success" of plugin "@semantic-release/github"

@semantic-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuwas
Copy link
Author

kuwas commented Oct 18, 2019

@pvdlg Confirmed fixed, thanks for the quick turnaround 🎉.

@semantic-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.6.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants