Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade semantic-release dependencies #207

Merged
merged 4 commits into from
Apr 11, 2023
Merged

fix: upgrade semantic-release dependencies #207

merged 4 commits into from
Apr 11, 2023

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Feb 24, 2023

BREAKING CHANGES:

  • This package is not compatible with semantic-release < 20.1.0.
  • The minimum supported Node version has been changed to 18.0.0.

BREAKING CHANGES:

- The plugin is not compatible with semantic-release < 20.1.0
- This package is now ESM-only and cannot be used by CJS packages.
- The minimum supported Node version has been changed to 18.0.0.
@travi
Copy link
Member

travi commented Feb 24, 2023

cannot be used by CJS packages

this might be slightly misleading. the consuming project itself can still be CJS, but the way semantic-release consumes this would need to follow ESM. since semantic-release is its own executable independent of the consuming project, that is fine from an ESM perspective as long as the project's release config is either using a .mjs extension or uses a non-js formatted config file.

however, that starts to step into the territory of this issue: semantic-release/semantic-release#2686

in addition, we deferred some of the complexities of loading esm configs that are extended within a project's config with the initial ESM conversion of core. this is our first case that might need to motivate us to push through that functionality.

it is good that we are starting with a pre-release here as i imagine that we will have some things to figure out about supported ways to consume this. if you have the time/energy to explore some of those, please feel free.

@travi
Copy link
Member

travi commented Mar 7, 2023

Please feel free to move forward with testing this out. I'm stepping away for a couple of weeks, but hoping that I won't be a blocker on this

@fgreinacher
Copy link
Contributor Author

I got derailed from this.

My main goal here was to unblock the upgrades in #198.

@travi Would it be enough to stick with CJS, get rid of xo and upgrade the minimum Node version?

@travi
Copy link
Member

travi commented Mar 31, 2023

Would it be enough to stick with CJS, get rid of xo and upgrade the minimum Node version?

i think that should work just fine. lets give it a shot with a beta release and make sure there are no surprises 👍🏼

@fgreinacher fgreinacher changed the title feat: convert package to ESM fix: upgrade semantic-release dependencies Apr 11, 2023
@fgreinacher
Copy link
Contributor Author

Would it be enough to stick with CJS, get rid of xo and upgrade the minimum Node version?

i think that should work just fine. lets give it a shot with a beta release and make sure there are no surprises 👍🏼

Looking good. I'll go ahead merge this to beta.

@fgreinacher fgreinacher merged commit 7438dff into beta Apr 11, 2023
4 checks passed
@fgreinacher fgreinacher deleted the feat/esm branch April 11, 2023 11:00
@github-actions
Copy link

🎉 This PR is included in version 10.0.2-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fgreinacher added a commit that referenced this pull request Apr 13, 2023
BREAKING CHANGE: This package is not compatible with semantic-release < 20.1.0
BREAKING CHANGE: The minimum supported Node version has been changed to 18.0.0
fgreinacher added a commit that referenced this pull request Apr 13, 2023
BREAKING CHANGE: This package is not compatible with semantic-release < 20.1.0
BREAKING CHANGE: The minimum supported Node version has been changed to 18.0.0
fgreinacher added a commit that referenced this pull request Apr 25, 2023
fix: upgrade semantic-release dependencies (#207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants