Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit yarn.lock #154

Closed
trollepierre opened this issue Apr 3, 2019 · 3 comments
Closed

Commit yarn.lock #154

trollepierre opened this issue Apr 3, 2019 · 3 comments

Comments

@trollepierre
Copy link

Read explanation here ;-)
https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

@gr2m
Copy link
Member

gr2m commented May 8, 2019

no thanks

@gr2m gr2m closed this as completed May 8, 2019
@trollepierre
Copy link
Author

Maybe I am too curious...
Why?
:p

@gr2m
Copy link
Member

gr2m commented May 19, 2019

We discussed adding lockfiles but decided against it. They lock all dependencies, so it’s possible that the library does not work for users while our tests pass, because of an outdated lockfile. The direct dependencies are checked by Greenkeeper in the background, but not the sub dependencies.

We might re-evaluate that decision in future. But if we commit a lock file, it will more likely be package-lock.json.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants