Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept BREAKING CHANGE"S" as major release trigger #1635

Closed
vis97c opened this issue Sep 9, 2020 · 2 comments
Closed

Accept BREAKING CHANGE"S" as major release trigger #1635

vis97c opened this issue Sep 9, 2020 · 2 comments

Comments

@vis97c
Copy link

vis97c commented Sep 9, 2020

New feature motivation

Currently to trigger a major release it is required to add BREAKING CHANGE to the body while this is not a problem there are moments where we could be adding more than a change. So i think it would be nice to accept this plural "BREAKING CHANGES", this would also prevent minor releases when we include the "s" at the by accident. I experienced this a lot, maybe because english is not my first language and i forgot to write the keyword as singular.

New feature description

This requires the commit analyzer to check wheter or not there is "BREAKING CHANGE" | "BREAKING CHANGES" present in the commit body

New feature implementation

I haven't check the code but it looks like an "or" could do the trick.

@travi
Copy link
Member

travi commented Sep 9, 2020

we use https://github.com/conventional-changelog/conventional-changelog to parse commits. requests to make any adjustments to how commits are parse would need to be proposed there.

you could also consider tools like commitizen and/or commitlint to help avoid problems like the one you mention.

@vis97c
Copy link
Author

vis97c commented Sep 9, 2020

Ok, thanks for the advice. I'm closing the issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants