Repository URL wrongly resolved

[SheepFromHeaven]

Current behavior

By passing no repositoryURL option and one malformed option to the cli and having a repository set in the package.json throws the error: ENOREPOURL.

Expected behavior

Wrongly set options passed to the cli and set repository url in the package json should throw a EWRONGOPTIONS error

Environment

• semantic-release version: 17.3.2
• CI environment: Local as well as as GITHUB Actions
• CLI Options: semantic-release -tagFormat '${version}'

I traced the bug to the following code snippet:
https://github.com/semantic-release/semantic-release/blob/master/lib/get-config.js#L83

As the pickBy filters by nil, but the cliOptions return repositoryUrl as empty string on error, the repositoryUrl being correctly extrapolated from the package.json gets overwritten here.

[gr2m]

so you say that we should also check for empty strings here?

semantic-release/lib/get-config.js

Lines 82 to 83 in 7581aa8

	// Remove `null` and `undefined` options so they can be replaced with default ones
	...pickBy(options, (option) => !isNil(option)),

That makes sense, could you send a pull request please?