fix: use one note reference per tag to prevent conflicts

[KillianHmyd]

Current behavior

All notes are pushed under the reference semantic-release because of that, if from two different branches and channels a release is performed at the same time the release would fail on one of them with this error :

 ! [rejected]        refs/notes/semantic-release -> refs/notes/semantic-release (fetch first)

New behavior

Instead of using only one note reference we would use one per tag, this way we could not have any conflict between multiple channels.
This change should be retro-compatible and doesn't need a migration.

resolves #1613

[KillianHmyd]

Hello @gr2m, is it possible to have your input on this PR 🙏 ?

[gr2m]

sorry for the lack of a response. We are currently focusing on migrating semantic-release to ESM. Once we are done with the transition we will get back to open PRs and issues, and will also onboard more maintainers

[KillianHmyd]

Good to know @gr2m 👍 Thanks for you answer

[gr2m]

We get to it. If you could please add a 👍🏼 emoji to the pull request instead of basically adding +1 comments, we'd appreciate it. It's only causing noise for us and everyone else watching the pull request.

We cannot give you an ETA but you can see more activity happening in @semantic-release again, so hopefully not to far out. We are close to wrapping up the transition to ES Modules which is our primary focus right now.

[nicolai-chisacov]

Hello! Are there any known workarounds, to make semantic-release plugin to not fail with mentioned above issue, on parallel release builds?

[mcmiddle592]

Hello, just wanted to mention that I pulled in @KillianHmyd branch into my release pipeline and it resolved my issues when releasing defect fixes to multiple Long Term Support (LTS) branches in a single repo at once. Without the changes I get the same error mentioned in the PR description whenever semantic-release runs on multiple branches in parallel on a single repo.

For those curious on how I did the test, I had to pull in the GitHub branch through npm like so:
npm i https://github.com/KillianHmyd/semantic-release.git#fix/notes-concurrency --save-dev --legacy-peer-deps

I had to add the following to my .npmrc file while testing the GitHub branch due to the branch not matching some of my peer dependency requirements mentioned in my package-lock.json: legacy-peer-deps=true. You can add this directly into your npm commands in your pipeline, but editing the .npmrc was the lowest impact change I could find.

Screenshot below is the error you get without this workaround:

[travi]

sorry for the delayed merge. thanks for the contribution!

[github-actions]

🎉 This PR is included in version 23.0.0-beta.5 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[travi]

please give the pre-release a try and report any complications. hoping to promote to stable in about a week

[KillianHmyd]

Hello @travi, just saw that you merged the PR thank you !
We will try the beta version and keep you updated.
For information, we are using my fork version since the creation of this PR in production environment. We haven't encounter any complications during the past 2 years

[github-actions]

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀