Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI build fails -- keytar can't find keyring #82

Closed
apowers313 opened this issue Sep 9, 2015 · 3 comments
Closed

Travis CI build fails -- keytar can't find keyring #82

apowers313 opened this issue Sep 9, 2015 · 3 comments

Comments

@apowers313
Copy link

I just started using semantic-release on a new project, and the build on Travis CI fails with the error:

> keytar@2.1.0 install /home/travis/build/apowers313/testing/node_modules/semantic-release-cli/node_modules/keytar
> node-gyp rebuild
Package gnome-keyring-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gnome-keyring-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gnome-keyring-1' found
gyp: Call to 'pkg-config --libs-only-l gnome-keyring-1' returned exit status 1. while trying to load binding.gyp
gyp ERR! configure error

I had to add the following to the .travis.yml to get it to work:

sudo: true
before_install:
  - sudo apt-get install libgnome-keyring-dev
@christophwitzko
Copy link
Contributor

Hi @apowers313,

there is no need to add semantic-release-cli to your devDependencies.
The semantic-release-cli is just used for setting up semantic-release on your repository.
You might install the CLI globally on your machine: npm install -g semantic-release-cli.

have a nice day,
Christoph

@apowers313
Copy link
Author

@christophwitzko Ah, now it makes sense why nobody else was running into this issue. Thanks for the help.

I'm actually using it as part of a template where I would expect others to run semantic-release-cli as part of the npm post-install process. I'll fix up the .travis.yml as part of my install process -- you can close out this issue.

On an unrelated topic, I found the undocumented use of keytar extremely disturbing when I realized that semantic-release-cli had saved my passwords without mentioning that was going to do so in the README or mentioning it as part of install script. The README doesn't even mention the command-line option for --no-keychain. I would advocate for defaulting keychain to false and updating the README. Happy to submit a PR if you guys are open minded to that.

@christophwitzko
Copy link
Contributor

@apowers313 nice 👍 ☺️

Regarding keytar: Sorry for the bad documentation. It would be awesome if you could create here an issue so we can discuss the further steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants