Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Use hyper native tls #123

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Use hyper native tls #123

merged 2 commits into from
Jul 4, 2017

Conversation

schultyy
Copy link
Member

Resolves #122 and based on #118

This fixes the problem described in #122 that GitHub rejects pushes performed over http. This is caused by hyper which does not ship with its own tls implementation anymore. We fix this by including hyper-native-tls and configuring out GitHub client explicitly to use https.

Jan Schulte added 2 commits May 14, 2017 15:48
as of hyper 0.10 it doesn't ship with a native tls implementation
anymore and has to be installed and configured separately.
@schultyy schultyy requested a review from badboy May 14, 2017 14:32
@badboy
Copy link
Member

badboy commented Jul 4, 2017

bors try

not-a-robot bot added a commit that referenced this pull request Jul 4, 2017
@not-a-robot
Copy link

not-a-robot bot commented Jul 4, 2017

Build succeeded

@badboy
Copy link
Member

badboy commented Jul 4, 2017

bors r+

not-a-robot bot added a commit that referenced this pull request Jul 4, 2017
123: Use hyper native tls r=badboy

Resolves #122 and based on #118 

This fixes the problem described in #122 that GitHub rejects pushes performed over http. This is caused by hyper which does not ship with its own tls implementation anymore. We fix this by including `hyper-native-tls` and configuring out GitHub client explicitly to use https.
@not-a-robot
Copy link

not-a-robot bot commented Jul 4, 2017

Build succeeded

@not-a-robot not-a-robot bot merged commit a3a30a8 into master Jul 4, 2017
@schultyy schultyy deleted the use-hyper-native-tls branch September 16, 2018 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git push fails with Invalid scheme for Http error
2 participants