This repository has been archived by the owner on Nov 13, 2021. It is now read-only.
Better git error #57
Merged
Better git error #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One warning remains: We need the temp variable in git.rs:121, because for some reason this satisfies the compiler to not complain about the repo living only shortly.
|
It should have a test before merging. Also: We need better error handling. |
|
@badboy Can this be merged or is there work to be done first? |
|
I'm not 100% satisfied with the user-visible error message. Gonna rewrite that and then merge it |
We're using the committer infomration for both, author and committer, anyway. Allowing both variables seems to be too confusing.
|
3256a8c now has a much nicer error message, which I took from 14ad9f0 removes support for the If you agree with all (and tests are green): Ready to merge. |
|
Forgot to remove one sentence, fixed in b278629 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice and long error message and fetching the git author name the same way real git does it.
I'm not 100% happy with the code and the error message could be improved as well.