Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with gist logo #750

Closed
rjyounes opened this issue Oct 6, 2022 · 2 comments · Fixed by #822
Closed

Fix issue with gist logo #750

rjyounes opened this issue Oct 6, 2022 · 2 comments · Fixed by #822

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Oct 6, 2022

Get the path in the README right so that it works both on GitHub and the README in the release package. In previous versions it was ![gist logo](gist.png) but now that doesn't work, so I've used the GitHub upload path instead. That means that README.html in the release package points to the image on GitHub, which isn't ideal. Need to look at previous versions to see how it was done.

@Jamie-SA
Copy link
Contributor

@Jamie-SA will look at this.

@Jamie-SA Jamie-SA self-assigned this Jan 26, 2023
@Jamie-SA
Copy link
Contributor

Jamie-SA commented Feb 8, 2023

I am not seeing the logo image in this repo. It seems to me that you either put the logo in this repo or you link to an externally hosted URL.

My Suggestion:

  • add the logo to the top level of repo
  • update bundle.yml to move logo to Documentation directory during the release bundling
  • change the README.md to reference the local logo file

If agreed to, I will submit a PR for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants