Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of gist:Magnitude #965

Closed
rjyounes opened this issue Sep 12, 2023 · 2 comments · Fixed by #1008
Closed

Fix definition of gist:Magnitude #965

rjyounes opened this issue Sep 12, 2023 · 2 comments · Fixed by #1008
Assignees
Labels
status: fast track A low impact change for which a PR can be submitted without group discussion type: bug

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Sep 12, 2023

Definition is now "Base class for units which can be converted. The primitive units can be converted from one measurement system to another; the complex units (ratio or product) have to decompose to their primitives."

Seems to be a copy-paste error. I think we can fix this before the major units and magnitudes refactoring, because unless I'm missing something it's an error.

@uscholdm
Copy link
Contributor

I propose:

skos:definition "A quantity expressed with a unit of measure and a number"^^xsd:string ;
skos:example "3 millimeters; 70 miles per hour; 110 degrees F"^^xsd:string ;

@rjyounes
Copy link
Collaborator Author

Looks good to me.

@rjyounes rjyounes added the status: fast track A low impact change for which a PR can be submitted without group discussion label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fast track A low impact change for which a PR can be submitted without group discussion type: bug
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants