Fix Store update when uploading a file (Bug 19487)

[mwjames]

[0] has been open and broken since 2009. The reason why the normal update hooks don't work is because there aren't executed in case of a file upload.

Investigate UploadVerifyFile (should be used as $mime is delivered by the interface) [1] or UploadComplete (doing $image->getLocalFile()->mime doesn't really work) [2].

Store update

$this->globals['wgHooks']['UploadVerifyFile'][] = function ( $upload, $mime, &$error ) use( $context ) {

    $title = $upload->getLocalFile()->getTitle();

    $contentParser = $context->getDependencyBuilder()->newObject( 'ContentParser', array(
        'Title' => $title
    ) );

    $contentParser->parse();

    $parserData = $context->getDependencyBuilder()->newObject( 'ParserData', array(
        'Title'        => $title,
        'ParserOutput' => $contentParser->getOutput()
    ) );

    $parserData->updateStore();

    return true;
};

Mime annotation

While resolving [0], the core should also add two new predefined properties _MIME and _MEDIA and annotate those for uploaded files with something like:

/**
 * @var PropertyAnnotator $propertyAnnotator
 */
$propertyAnnotator = $context->getDependencyBuilder()->newObject( 'FilePropertyAnnotator', array(
    'SemanticData'  => $parserData->getSemanticData(),
    'MimeType' => $mime
    'MediaType'   => $image->getLocalFile()->media_type
) );

$propertyAnnotator->attach( $parserData )->addAnnotation();

Reference

[0] https://bugzilla.wikimedia.org/show_bug.cgi?id=19487
[1] https://www.mediawiki.org/wiki/Manual:Hooks/UploadVerifyFile
[2] https://www.mediawiki.org/wiki/Manual:Hooks/UploadComplete
[3] https://gerrit.wikimedia.org/r/#/c/50943/

See also

#128

[mwjames]

It took me some time to find the least intrusive implementation to ensure that data before and after the upload is correctly derived from the FilePage object. UploadVerifyFile and UploadComplete are inappropriate hooks therefore FileUpload is used instead.

Activating _MEDIA and _MIME annotation with $GLOBALS['smwgPageSpecialProperties'] = array( '_MEDIA', '_MIME' ); requires SMWAdmin to be executed once in order for the property tables to be initialized.

Checking table `smw_fpt_mime` ...
   Table not found, now creating...
   ... done.
Checking index structures for table `smw_fpt_mime` ...
   ... creating new index s_id ...done.
   ... creating new index o_hash ...done.
   ... done.
Checking table `smw_fpt_media` ...
   Table not found, now creating...
   ... done.
Checking index structures for table `smw_fpt_media` ...
   ... creating new index s_id ...done.
   ... creating new index o_hash ...done.
   ... done.

[kghbln]

Just closed bug 19487 on bugzilla!

[mwjames]

Just closed bug 19487 on bugzilla!

It just took 5 years ;-)

[JeroenDeDauw]

It just took 5 years ;-)

Still fast compared to MW core review :D