refactor(group): remove check on generateMerkleProof function

Contracts actually need devs to generate a Merkle proof of a removed member. re #717 Former-commit-id: 0014365
semaphore-protocol · Mar 28, 2024 · 2b7dbf3 · 2b7dbf3
1 parent ea21454
commit 2b7dbf3
Show file tree

Hide file tree

Showing 12 changed files with 32,334 additions and 19 deletions.
diff --git a/.yarn/releases/yarn-4.1.0.cjs b/.yarn/releases/yarn-4.1.0.cjs
diff --git a/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id b/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id
diff --git a/packages/cli-template-contracts-hardhat/.yarn/releases/yarn-4.1.0.cjs b/packages/cli-template-contracts-hardhat/.yarn/releases/yarn-4.1.0.cjs
diff --git a/packages/cli-template-contracts-hardhat/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id b/packages/cli-template-contracts-hardhat/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id
diff --git a/packages/cli-template-monorepo-ethers/.yarn/releases/yarn-4.1.0.cjs b/packages/cli-template-monorepo-ethers/.yarn/releases/yarn-4.1.0.cjs
diff --git a/packages/cli-template-monorepo-ethers/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id b/packages/cli-template-monorepo-ethers/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id
diff --git a/packages/cli-template-monorepo-subgraph/.yarn/releases/yarn-4.1.0.cjs b/packages/cli-template-monorepo-subgraph/.yarn/releases/yarn-4.1.0.cjs
diff --git a/packages/cli-template-monorepo-subgraph/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id b/packages/cli-template-monorepo-subgraph/.yarn/releases/yarn-4.1.0.cjs.REMOVED.git-id
diff --git a/packages/group/src/index.ts b/packages/group/src/index.ts
@@ -124,10 +124,6 @@ export class Group {
      * @returns The {@link MerkleProof} object.
      */
     public generateMerkleProof(index: number): LeanIMTMerkleProof {
-        if (this.members[index] === 0n) {
-            throw new Error("Failed to generate Merkle proof: member has been removed")
-        }
-
         return this.leanIMT.generateProof(index)
     }
 

diff --git a/packages/group/tests/index.test.ts b/packages/group/tests/index.test.ts
@@ -125,16 +125,6 @@ describe("Group", () => {
 
             expect(proof.leaf).toBe(1n)
         })
-
-        it("Should not generate a proof of membership if the member has been removed", () => {
-            const group = new Group()
-            group.addMembers([1n, 3n])
-            group.removeMember(0)
-
-            const fun = () => group.generateMerkleProof(0)
-
-            expect(fun).toThrow("Failed to generate Merkle proof: member has been removed")
-        })
     })
 
     describe("# export", () => {