Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shortcut for approving test output #50

Open
mjambon opened this issue Mar 29, 2024 · 0 comments
Open

Add a shortcut for approving test output #50

mjambon opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mjambon
Copy link
Member

mjambon commented Mar 29, 2024

Here's how I review a test right now:

$ ./test status -s 8bdf63abd0d3 -l

If I'm happy with the output, I have to run the following command:

$ ./test approve -s 8bdf63abd0d3

It would be faster if I could just append a + to the status command that I typed earlier:

./test status -s 8bdf63abd0d3 -l +

Proposal 1: a + argument in the status command will approve the selected tests after printing their status as usual.

Proposal 2: same as proposal 1 but asks for confirmation. The user needs to enter y or n to approve all the selected tests that need approval.

Proposal 3: same as proposal 1 but asks for confirmation for each selected test that needs approval.

Proposal 4 (similar to proposal 3): a + argument in the status command causes, after printing the status of a test, to ask the user whether they want to approve this test before moving on to the next test.

See also #38.

@mjambon mjambon added the enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant