Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Typescript? #19

Closed
bkoltai opened this issue Apr 11, 2021 · 6 comments
Closed

Convert to Typescript? #19

bkoltai opened this issue Apr 11, 2021 · 6 comments

Comments

@bkoltai
Copy link

bkoltai commented Apr 11, 2021

Would you be open to converting this package to TS so people can get autocomplete when using the builder pattern?

@etiennedi
Copy link
Member

Great idea. Let's investigate how big of a change that would be. But I totally see the benefits of better tooling support.

@e-001
Copy link

e-001 commented Feb 28, 2022

Conversion is a full solution, but providing typings via a declaration file would be just as useful. I'll take a stab.

@erikvullings
Copy link

@e-001 Just wondering if you are still working on a declaration file. I would be very much interested in it!

@cnadeau
Copy link
Contributor

cnadeau commented Feb 21, 2023

I have done the conversion, I'll create a PR within the next week. I found some part of the code that were broken according to types I created. I'll create a different commits for conversion vs fixes.

@dirkkul
Copy link
Collaborator

dirkkul commented Feb 22, 2023

That is very cool, looking forward to your PR!

@dirkkul
Copy link
Collaborator

dirkkul commented Mar 8, 2023

closed by #121
Follow-up issue for missing types: #129

Thanks a bunch @cnadeau !

@dirkkul dirkkul closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants