Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate which other (if any) db.Migrator methods need to be implemented #1306

Closed
3 tasks done
etiennedi opened this issue Nov 24, 2020 · 1 comment
Closed
3 tasks done
Assignees
Milestone

Comments

@etiennedi
Copy link
Member

etiennedi commented Nov 24, 2020

Background

It is impossible to tell at the moment which methods in the interface that db.Migrator tries to implement actually need to contain an implementation. It seems some of them are also not implemented in esvector. Others are stubbed out in esvector (just returning nil, but no error).

Goals

  • find out if any of the currently not-implemented methods are actually required
  • if yes, create issues for the missing methods
  • if no, delete the missing methods from the interface and cleanup in the associated usecase.
@etiennedi etiennedi added this to the Standalone milestone Nov 24, 2020
@etiennedi
Copy link
Member Author

cc @laura-ham This is related to what we talked about yesterday: You mentioned schema-related API methods that possibly still exist and can't be used. This issue has the same underlying problem - only that its affect are the respective methods on the standalone and es packages.

Either way we should clean this up as part of either the v0.23.0 or the v1.0.0 release.

@etiennedi etiennedi added the prio label Dec 1, 2020
@etiennedi etiennedi changed the title Investigate which db.Migrator methods need to be implemented Investigate which other (if any) db.Migrator methods need to be implemented Dec 1, 2020
@antas-marcin antas-marcin self-assigned this Dec 2, 2020
etiennedi added a commit that referenced this issue Dec 7, 2020
…one-missing-methods

gh-1306 Investigate which other (if any) db.Migrator methods need to be implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants