Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: valueBoolean==false returns no results #1308

Closed
etiennedi opened this issue Nov 25, 2020 · 0 comments · Fixed by #1309
Closed

Bug: valueBoolean==false returns no results #1308

etiennedi opened this issue Nov 25, 2020 · 0 comments · Fixed by #1309
Assignees
@etiennedi
Labels
bug
Milestone
Standalone

Comments

@etiennedi
Copy link
Member

How to reproduce

  • Import 20news dataset (using 80% training factor - not sure if that's releveant)
  • Trigger kNN classification This is an important step, the bug does not occur without this
  • search for training == false

Expected results

We see all the items that have training == false

Actual results

We see no results

Initial investigation

The classification causes on update on each object, so when writing the update, something seems to break. Probably related to the immutable docID feature.
@etiennedi etiennedi added this to the Standalone milestone Nov 25, 2020
@etiennedi etiennedi self-assigned this Nov 25, 2020
etiennedi added a commit that referenced this issue Nov 25, 2020
@etiennedi
gh-1308 add in-memory deleted docid tracker
b7969a1
etiennedi added a commit that referenced this issue Nov 25, 2020
@etiennedi
gh-1308 check in-mem deleted tracker in searcher
471d1a9 
This commit also adds a new integration test to make sure that the bug
we encountered in #1308 does not re-appear.
etiennedi added a commit that referenced this issue Nov 25, 2020
@etiennedi
gh-1308 add missing methods to deleted-id-tracker
c22dc59
@etiennedi etiennedi mentioned this issue Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etiennedi etiennedi

Labels
bug
Projects
None yet
Milestone
Standalone
Development

Successfully merging a pull request may close this issue.

Bugfix 1308 weaviate/weaviate
1 participant
@etiennedi