Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1308 #1309

Merged
merged 5 commits into from Nov 25, 2020
Merged

Bugfix 1308 #1309

merged 5 commits into from Nov 25, 2020

Conversation

etiennedi
Copy link
Member

@etiennedi etiennedi commented Nov 25, 2020

@etiennedi etiennedi added this to the Standalone milestone Nov 25, 2020
@antas-marcin antas-marcin self-requested a review November 25, 2020 13:28
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1309 (94275ed) into master (bcdce1a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   73.73%   73.77%   +0.04%     
==========================================
  Files         212      213       +1     
  Lines       21303    21338      +35     
==========================================
+ Hits        15707    15742      +35     
+ Misses       4341     4337       -4     
- Partials     1255     1259       +4     
Flag Coverage Δ
integration 68.37% <100.00%> (+0.15%) ⬆️
unittests 73.77% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/repos/db/aggregator/aggregator.go 75.75% <100.00%> (+1.56%) ⬆️
adapters/repos/db/aggregator/filtered.go 78.21% <100.00%> (ø)
adapters/repos/db/aggregator/grouper.go 77.50% <100.00%> (ø)
adapters/repos/db/docid/deleted_tracker.go 100.00% <100.00%> (ø)
adapters/repos/db/inverted/searcher.go 77.72% <100.00%> (+1.69%) ⬆️
adapters/repos/db/shard.go 55.84% <100.00%> (+0.58%) ⬆️
adapters/repos/db/shard_aggregate.go 100.00% <100.00%> (ø)
adapters/repos/db/shard_read.go 63.77% <100.00%> (+0.57%) ⬆️
adapters/repos/db/shard_write_delete.go 41.17% <100.00%> (+1.78%) ⬆️
adapters/repos/db/shard_write_put.go 59.09% <100.00%> (+0.47%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fcb7b...94275ed. Read the comment docs.

@antas-marcin antas-marcin merged commit 11d5b66 into master Nov 25, 2020
@reyreaud-l reyreaud-l deleted the bugfix-1308 branch January 26, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: valueBoolean==false returns no results
2 participants