Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aggregator): Add support for multiple signers in input #211

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

aasseman
Copy link
Collaborator

@aasseman aasseman commented Feb 3, 2024

Lets the aggregator accept receipts or input RAVs that are signed with other keys.
Helpful with dealing with the transition when rotating keys, or making sure that we can accept receipts signed by other signing keys belonging to the same Sender (multiple locations with different keys for example).

Fixes #205

@aasseman aasseman added the enhancement New feature or request label Feb 3, 2024
@aasseman aasseman requested a review from Theodus February 3, 2024 03:33
@aasseman aasseman self-assigned this Feb 3, 2024
@coveralls
Copy link

coveralls commented Feb 3, 2024

Pull Request Test Coverage Report for Build 7764301533

  • -11 of 53 (79.25%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 73.81%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_aggregator/src/server.rs 19 20 95.0%
tap_aggregator/src/aggregator.rs 23 26 88.46%
tap_aggregator/src/main.rs 0 7 0.0%
Totals Coverage Status
Change from base Build 7762886114: 0.1%
Covered Lines: 1364
Relevant Lines: 1848

💛 - Coveralls

Fixes #205

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

This comment has been minimized.

1 similar comment
Copy link

github-actions bot commented Feb 3, 2024

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit b16f23d into main Feb 8, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/issue205 branch February 8, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Aggregator) Add support for multiple signing keys
3 participants