Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issues with fastlane graphics #90

Closed
IzzySoft opened this issue Jan 18, 2024 · 9 comments
Closed

minor issues with fastlane graphics #90

IzzySoft opened this issue Jan 18, 2024 · 9 comments

Comments

@IzzySoft
Copy link

Just to point out two minor issue with your fastlane graphics:

  • screenshots have the wrong proportions (they are about twice as high as they should be)
  • if your header.png was named featureGraphic.png it could be used as such, proportions match the specs exactly 😉

Thanks for checking (and hopefully adjusting)!

@Semper-Viventem
Copy link
Owner

Hey, thank you for noticing @IzzySoft. Could you specify the correct size of the screenshots? I'll re-do all of them soon anyway

@IzzySoft
Copy link
Author

Oof. I don't know the correct size – just that there's a check about proportions which yours currently don't meet. Let me ask the all-knowing Internet for you … hm, seems if it's all-knowing it's not all-finding. It was something like 1:2, or between 1:1.7 and 1:2 as far as I remember. PlayStore seems to want 16:9 or 9:16 according to one documentation I found, which falls into that range (1:1.77) – another mentions "The maximum screenshot dimension can't be more than twice as long as the minimum dimension (2:1 aspect ratio)" – which again matches. So that should be the safe range.

Another hint I found in several notes: "Min length for any side: 320px, Max length for any side: 3840px, Max aspect ratio: 2:1."

@Semper-Viventem
Copy link
Owner

Hey, I've updated screenshots and featureGraphic, so they should be fine now. Thank you for your help!

@IzzySoft
Copy link
Author

featureGraphic looks good! But what happened with the aspect ratio of the screenshots? (picking up the calc) 2400/1080 hm, that thing says 2,222222222. Need a mathematician here. Is that between 1.7 and 2.0? Guess one could convince bard and GPT to confirm – but could you please check again? 🙈

Apologies for the phrasing, but I could not resist… They unfortunately do not meet the specs still, though it's better than before. Do you think you could fix that – or will you let it stay at that? While "1:2 pics" might not fill a screen that has an 1:3 ratio in height, at least all details would be visible on screens with a ratio of 1:2 then. The 2.22222 ratio pics would need to decreased in size to fit the height, and thus get hard to read. Not sure if apps would resize or scroll then, though, but neither would be ideal I guess.

@Semper-Viventem
Copy link
Owner

Hmm, I changed the screenshots for Google Play first and this aspect ratio was fine. Let me redo it on another emulator.

@Semper-Viventem
Copy link
Owner

@IzzySoft The problem is that most modern smartphones have a longer display with an aspect ratio >2. Even 9:16 is specific for old models like Pixel/Pixel 2. I can add screenshots from Pixel 2 (9:16) but I would prefer to have a modern display representation on the F-Droid page.

@IzzySoft
Copy link
Author

I wonder that PlayStore accepted them. I'm not using PlayStore myself, nor am I an Android developer so I do not submit any apps there – but from what I saw of their rules I thought they meanwhile isisted of something close to 16:9 (see above).

but I would prefer to have a modern display representation on the F-Droid page.

What are "modern display representations"? I only now few devices coming with display ratios beyond 1:2. This might be subjective, but to me those ratios seem "unnatural".

If you insist, I can take the 1:2.222222 ones currently there. Going to 1:2 was rather a suggestion of mine, not a strict requirement. Just the previous ones were quite a bit beyond. Remember the screenshots are also shown inside the F-Droid clients on phones – and as outlined, most of them come with a screen ratio closer to 1:2.

@Semper-Viventem
Copy link
Owner

Google Play still has a recommendation to provide 16:9 screenshots but accepts 20:9 as well. My point is that most modern smartphones have taller screens here are a few examples of 2023 smartphones:

  • Pixel 8: 20:9
  • Galaxy s23: 19.5:9
  • Pixel 7: 20:9
  • Asus Zenphone 10: 20:9
  • OnePlus 11 Pro: 20.1:9
  • Galaxy Fold 5: 22:9

The screenshots I've added in the metadata are 20:9 exactly, It is pretty close to 2:1 as you mentioned above. If you need exactly 16:9, I can provide it for you outside of the phoneScreenshots metadata, but based on my statistics, this is a pretty rare aspect ratio in nowadays

@IzzySoft
Copy link
Author

Not sure if that covers "most" modern smartphones (and again, "modern" is quite subjective). My current phone as a resolution of 1080 x 2160 px (a perfect 1:2) and suits me well. My new one (hopefully arriving in May) will have 1080 x 2400 px – which exactly meets your 1:2222 indeed. The Fairphone 4 comes at 1:2.16667, the FP5 again at 1:2.2.

Well, I'm used for my devices to last. My main driver is still a FP2 from 2015 (1:1.7777; this is the one to be replaced in May by a SHIFTphone8), with the SHIFT6mq accompanying it (the "current one" from above; one is for private, the other for business, hence 2 at the same time). My repo is focused at devices to last, too, hence that's what I "target".

But OK, checking devices I tend to associate with (fair, lasting, repairable, sustainable, good support etc) and where their newer models go, I see you have a point there. While I still favor aspect ratios of 1:≤2, probably half of those using my repo might not (and I might get used to the new formats once my phone8 becomes my new main driver – after all, I did in the past, considering my first smartphone came at 1:1.333 with its 240x320 px display 🙈).

Well then, let's give this a try – the "wide ones" shown currently in my repo aren't exactly ideal either 🙈 I've set my updater to look for featureGraphic and screenshots as well now, manually triggered a fastlane update here, and currently the index is updating. Maybe it doesn't look as "weird" as I feared after all. There we go:

image

So thanks, seems fine! Let's leave it at that then. Just don't go to something like 1:4 one day please 🙈

And thanks for your patience with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants