Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noindex for paginated pages/posts is being applied to archives #906

Closed
wpsmort opened this issue May 23, 2017 · 2 comments
Closed

Use noindex for paginated pages/posts is being applied to archives #906

wpsmort opened this issue May 23, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@wpsmort
Copy link

wpsmort commented May 23, 2017

The Use noindex for paginated pages/posts option should only apply to posts and pages, but it's being applied incorrectly to categories, tags and other archives.

Need to test to see if this is happening for Use nofollow for paginated pages/posts and Remove Descriptions For Paginated Pages as well.

The code is a jumbled mess and needs to be cleaned up. We also need to improve the filter hooks and documentation.

@wpsmort wpsmort added this to the 2.3.13 milestone May 23, 2017
@wpsmort wpsmort self-assigned this May 23, 2017
@wpsmort
Copy link
Author

wpsmort commented May 23, 2017

I have tested this and confirmed that all three settings apply to all paginated content including pages, posts, CPTs, blog page, category, tag, taxonomy, date and author archives.

The three settings should only apply to pages, posts and CPTs. They should not apply to archives.

We need to make the following changes:

1). Change the behavior of the three settings so they only apply to pages, posts and CPTs
2). Add a filter for noindex paginated content that can be used with any conditional tag
3). Add a filter for nofollow paginated content that can be used with any conditional tag
4). Add a filter for remove descriptions for paginated content that can be used with any conditional tag

Once this is done we should update the help text and documentation to reflect that these settings only apply to pages, posts, and CPTS, add new documentation for the filters and open a new issue for trimming these three options.

@wpsmort wpsmort removed their assignment May 23, 2017
@wpsmort wpsmort modified the milestones: 2.3.13, 2.3.14 May 31, 2017
@wpsmort wpsmort modified the milestones: 2.3.15, 2.3.14 Jun 30, 2017
@wpsmort wpsmort modified the milestones: 2.3.15, 2.3.16 Jul 11, 2017
@wpsmort wpsmort modified the milestones: 2.3.16, 2.3.17 Aug 17, 2017
@wpsmort wpsmort modified the milestones: 2.3.17, 2.5 Sep 5, 2017
@michaeltorbert michaeltorbert modified the milestones: 2.5, Future Release Mar 22, 2018
@arnaudbroes arnaudbroes self-assigned this Jul 27, 2019
@arnaudbroes arnaudbroes modified the milestones: Future Release, 3.2 Jul 27, 2019
@arnaudbroes
Copy link
Contributor

@wpsmort I've fixed (1). I don't think additional filters are needed here since we have the aioseop_robots_meta filter which can be used to filter the robots meta tag value. Our documentation was missing but I added it about a week ago - https://semperplugins.com/documentation/aioseop-robots-meta/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants