Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle scheme-less urls #1286

Merged
merged 14 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@contactashish13
Copy link
Contributor

commented Oct 9, 2017

No description provided.

contactashish13 added some commits Oct 9, 2017

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

@contactashish13 I'm confused why this fixes anything. It looks like it's just changing it to Yoda conditions.

@contactashish13

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2017

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

@contactashish13 Yep. My bad, I totally missed that. My eyes need a break.

@michaeltorbert

This comment has been minimized.

Copy link
Member

commented Dec 9, 2017

This fixes #1390 #1246 and #1283
For #1246 instead of ignoring URLs it adds the fully qualified domain name

contactashish13 added some commits Feb 9, 2018

Merge remote-tracking branch 'refs/remotes/semperfiwebdesign/master' …
…into #1283

# Conflicts:
#	tests/modules/sitemap/test-sitemap.php

@michaeltorbert michaeltorbert modified the milestones: 2.4.6, 2.4.7 Mar 15, 2018

michaeltorbert and others added some commits Mar 15, 2018

Merge pull request #1610 from semperfiwebdesign/development
Development to master for 2.4.6

@wpsmort wpsmort modified the milestones: 2.4.7, 2.5 Mar 20, 2018

@wpsmort wpsmort changed the base branch from development to 2.5 Mar 20, 2018

@wpsmort wpsmort removed the Needs Testing label Mar 20, 2018

@wpsmort wpsmort assigned michaeltorbert and unassigned wpsmort Mar 20, 2018

@wpsmort

This comment has been minimized.

Copy link
Member

commented Mar 20, 2018

This is tested. I tested each issue covered by this PR and made sure that GWT did not report any errors with the XML Sitemap. This is ready for code review.

@michaeltorbert michaeltorbert merged commit 7436f69 into semperfiwebdesign:2.5 Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.