Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination not applied to custom canonical URLs #1473

Closed
wants to merge 11 commits into from

Conversation

contactashish13
Copy link
Contributor

@contactashish13 contactashish13 commented Jan 13, 2018

@awesomemotive awesomemotive deleted a comment Feb 26, 2018
@michaeltorbert michaeltorbert added this to the 2.6 milestone Mar 22, 2018
@wpsmort wpsmort self-assigned this May 15, 2018
@wpsmort wpsmort changed the base branch from development to 2.6 May 15, 2018 20:38
@wpsmort wpsmort assigned contactashish13 and unassigned wpsmort May 15, 2018
@wpsmort wpsmort modified the milestones: 2.6, 2.7, Future Release May 15, 2018
@wpsmort wpsmort changed the base branch from 2.6 to 2.8 August 16, 2018 21:08
@wpsmort wpsmort changed the base branch from 2.8 to development August 16, 2018 21:09
@michaeltorbert michaeltorbert changed the base branch from development to 2.9 October 9, 2018 15:22
@michaeltorbert michaeltorbert modified the milestones: Future Release, 2.9 Oct 9, 2018
@contactashish13
Copy link
Contributor Author

@michaeltorbert I don't know what's going on in this PR. I tried to resolve the conflicts and once I try to merge, it says "This page is out of date. Start over" (screenshot). Tried doing this multiple times and its the same every time.

image

@michaeltorbert
Copy link
Contributor

@contactashish13 Are these the only changes (other than automated test)? If so, surely it would only take a few minutes to recreate in another PR?

screen shot 2018-10-10 at 3 51 33 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants