Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on the subfigure package #23

Open
Alex-Cremers opened this issue Oct 22, 2023 · 3 comments
Open

Dependency on the subfigure package #23

Alex-Cremers opened this issue Oct 22, 2023 · 3 comments

Comments

@Alex-Cremers
Copy link

It would be great to switch to subcaption, as subfigure hasn't been updated since 2005 and causes a lot of errors. Maybe making it an option for backward compatibility.

@fintelkai
Copy link
Contributor

We'll look into it. I don't think we haven't seen errors in our S&P production work. Can you elaborate on the errors you're getting? Is subcaption a drop-in replacement?

@Alex-Cremers
Copy link
Author

I don't think it's a drop-in replacement, as subfigure uses \subfigure{...} while subcaption uses \begin{subfigure}.... Another alternative then might be the subfig package, but I'm not familiar with it, so I can't guarantee it's a perfect fit.

The last error I encountered is the one described here, but I remember getting different errors when typesetting a paper for GlossaPX a year ago (Glossa uses a stylesheet derived from S&P; there was a project to write a specific stylesheet for GlossaPX, no idea how much progress has been done).

I wish I had the time to propose a solution instead of just complaining!

@rawlins
Copy link
Contributor

rawlins commented Oct 23, 2023

It seems very reasonable to me to change this as it's very clearly marked as obsolete on https://ctan.org/pkg/subfigure?lang=en, and it's rarely used by semprag: I counted 6 papers in the production archive. However, of those 6, two are in active production right now and one is in the deep backlog. I don't think it's worth keeping backwards compatibility in general because it's so rarely used, but we should either hold off on a change until after those are out, or actively test it out (possibly Grusdt, Lassiter, and Franke would be a good place to test out this change -- Aloni is near done iirc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants