Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated syntax for future rstan compatibility #22

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Update deprecated syntax for future rstan compatibility #22

merged 2 commits into from
Sep 8, 2023

Conversation

andrjohns
Copy link
Contributor

Now that rstan 2.26 is available on CRAN we need to update the deprecated syntax in your package's Stan models, otherwise it will fail to install with an upcoming version of RStan.

The following updates have been made:

  • New array syntax
  • _cdf functions using conditional | notation (i.e., _cdf(y |x))
    • The current CRAN rstan has a bug in recognising this in _cdf functions, so I've updated your syntax to work on the log scale with the _lcdf function. This will let your package be compatible with the current and future parser, and is also more numerically stable with extreme values (bonus!)

More information about the deprecated and removed syntax in Stan can be found here:

If you could merge and submit to CRAN soon, it would be greatly appreciated.

Let me know if you have any questions about these changes.

Thanks!

@sempwn sempwn merged commit ce38f70 into sempwn:main Sep 8, 2023
5 checks passed
@sempwn
Copy link
Owner

sempwn commented Sep 8, 2023

@andrjohns Great to hear that rstan 2.26 is now on CRAN. I've merged your PR and will release a new version to CRAN soon. Thank you for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants