Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenrpc generate very slow #35

Open
digitive opened this issue Dec 3, 2018 · 4 comments
Open

zenrpc generate very slow #35

digitive opened this issue Dec 3, 2018 · 4 comments

Comments

@digitive
Copy link

digitive commented Dec 3, 2018

Hi
We love zenrpc.
We just experienced the zenrpc code generator being very slow. We have a small project which about 10 methods in 2 files, which takes zenrpc more than 1 minutes to generate. And the CPU usage are very high during the generating process.

@sergeyfast
Copy link
Contributor

@digitive could you please check new v2 version? We've made some improvements in generator.

@smyrman
Copy link

smyrman commented Mar 10, 2021

We are using:

github.com/semrush/zenrpc/v2 v2.1.0 h1:a6jKcimSTS2u/FkAg8qXkAcplBC9vEAInl7aQY47u7g=
github.com/semrush/zenrpc/v2 v2.1.0/go.mod h1:+o94fyVC+TvYuT5ULLyBmql+ezicEFKtsieIXSeWBqg=

Macbook Pro with SSD and CPU:

 % sysctl -n machdep.cpu.brand_string
Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz

Generating 15 services in ~60 seconds:

tusk generate  60.95s user 34.96s system 172% cpu 55.478 total

@sergeyfast
Copy link
Contributor

@smyrman are you using heavy imports like s3?
How can we reproduce this issue? Could you provide test project?

@smyrman
Copy link

smyrman commented Apr 6, 2021

Hi, sorry for the late reply.

Unfortunately we do not have a reproduce code we can share for the 15 services example. At the moment, I also do not have the time to setup a reproduce test repo, but if I find the time later, I will let you know. I can mention the different services reside in different packages, so each run of zenrpc for one service in particular generally run for 14 - 24 sec depending on the service.

PS! I have no connection to @digitive. I just saw there where no update on this issue and wanted to contribute to show which numbers we are seeing in our organization to see if it's relatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants