Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD wallet from CLI - do we force HD generation on start? #99

Closed
orogvany opened this issue Nov 19, 2018 · 5 comments
Closed

HD wallet from CLI - do we force HD generation on start? #99

orogvany opened this issue Nov 19, 2018 · 5 comments
Assignees
Milestone

Comments

@orogvany
Copy link
Collaborator

I wonder about exchange updating wallet. Does the startup of CLI on update prompting to create HD key pose a problem to update path for existing wallets?

If I am network admin for an exchange tasked with updating wallet, should I be privy to the HD key backup key/phrase?

Should we allow an option to continue without an HD wallet as default behavior from CLI, and only prompt to create if they try to add a new account from CLI?

@orogvany orogvany added this to the v1.5.0 milestone Nov 19, 2018
@honeycrypto
Copy link
Contributor

honeycrypto commented Nov 20, 2018

I think we should move to HD wallets only when we are sure that they are safe to use. While users can still backup their wallet.data, the only official recommended way to backup a wallet should be seed.

For sure, we need to warn Stex in advance about this change.

@orogvany
Copy link
Collaborator Author

They are safe to use, as the mechanism is identical to that used across 100+ other coins.

Wallet or seed, same same. Both are supported backup paths

@orogvany
Copy link
Collaborator Author

orogvany commented Jul 5, 2019

Depends on #171

@orogvany orogvany modified the milestones: v1.5.0, v1.6.0 Jul 5, 2019
@orogvany
Copy link
Collaborator Author

orogvany commented Jul 5, 2019

Moved to 1.6.0, as it is not required for VM release, no fork required, and we should make sure exchanges are informed/aware.

@semuxgo semuxgo added Crypto and removed Crypto labels Jul 6, 2019
@orogvany
Copy link
Collaborator Author

This has been resolved to be opt in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants